Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/display/mojo/display_struct_traits_unittest.cc

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)
Patch Set: size_ is initialized by default. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/mojo/display_struct_traits_unittest.cc
diff --git a/ui/display/mojo/display_struct_traits_unittest.cc b/ui/display/mojo/display_struct_traits_unittest.cc
index a223bddff8299a14769eaac94a5864372ec943d5..1797e6e847d3c198676cc3af087ba8d381ec3862 100644
--- a/ui/display/mojo/display_struct_traits_unittest.cc
+++ b/ui/display/mojo/display_struct_traits_unittest.cc
@@ -7,6 +7,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/display/display.h"
#include "ui/display/mojo/display_struct_traits_test.mojom.h"
+#include "ui/display/types/display_mode.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
@@ -31,6 +32,11 @@ class DisplayStructTraitsTest : public testing::Test,
callback.Run(in);
}
+ void EchoDisplayMode(const DisplayMode& in,
+ const EchoDisplayModeCallback& callback) override {
+ callback.Run(in);
+ }
+
base::MessageLoop loop_; // A MessageLoop is needed for Mojo IPC to work.
mojo::BindingSet<mojom::DisplayStructTraitsTest> traits_test_bindings_;
@@ -79,4 +85,20 @@ TEST_F(DisplayStructTraitsTest, SetAllDisplayValues) {
CheckDisplaysEqual(input, output);
}
+TEST_F(DisplayStructTraitsTest, DefaultDisplayMode) {
+ // Prepare sample input with random values
+ const DisplayMode input(gfx::Size(15, 29), true, 61.0);
+
+ mojom::DisplayStructTraitsTestPtr proxy = GetTraitsTestProxy();
+ DisplayMode output;
+
+ EXPECT_TRUE(proxy->EchoDisplayMode(input, &output));
+
+ // We want to test each component individually to make sure each data member
+ // was correctly serialized and deserialized.
+ EXPECT_EQ(input.size(), output.size());
+ EXPECT_EQ(input.is_interlaced(), output.is_interlaced());
+ EXPECT_EQ(input.refresh_rate(), output.refresh_rate());
+}
+
} // namespace display

Powered by Google App Engine
This is Rietveld 408576698