ui/display/mojo/OWNERS - Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/mojo/OWNERS

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)

Patch Set: Change structure not to use display_mode_mojo.(cc|h). Instead, use friend class in display_mode.h. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 per-file _struct_traits.*=set noparent

	2 per-file _struct_traits.*=file://ipc/SECURITY_OWNERS

	3 per-file *.mojom=set noparent

	4 per-file *.mojom=file://ipc/SECURITY_OWNERS

	5 per-file *.typemap=set noparent
	kylechar 2017/01/25 16:59:44 Just curious, why did you add the .typemap per fi Just curious, why did you add the .typemap per file? thanhph1 2017/01/25 20:28:39 I got this error message on "git cl upload" if I d Show quoted text On 2017/01/25 16:59:44, kylechar wrote: > Just curious, why did you add the .typemap per file? I got this error message on "git cl upload" if I dont have .typemap lines Presubmit Warnings Found changes to IPC files without a security OWNER! *************** ui/display/mojo/OWNERS is missing the following lines: per-file .typemap=set noparent per-file .typemap=file://ipc/SECURITY_OWNERS for changed files: ui/display/mojo/display_mode.mojom ui/display/mojo/display_struct_traits_test.mojom ui/display/mojo/display_mode_struct_traits.h ui/display/mojo/display_struct_traits_unittest.cc ui/display/mojo/display_mode.typemap
	6 per-file *.typemap=file://ipc/SECURITY_OWNERS

OLD	NEW