Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: ui/display/types/display_mode.h

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)
Patch Set: Dont need to make changes in ui/ozone/common/BUILD.gn. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 5 #ifndef UI_DISPLAY_TYPES_DISPLAY_MODE_H_
6 #define UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 6 #define UI_DISPLAY_TYPES_DISPLAY_MODE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <ostream> 9 #include <ostream>
10 #include <string> 10 #include <string>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "ui/display/types/display_types_export.h" 13 #include "ui/display/types/display_types_export.h"
14 #include "ui/gfx/geometry/size.h" 14 #include "ui/gfx/geometry/size.h"
15 15
16 namespace display { 16 namespace display {
17 17
18 // This class represents the basic information for a native mode. Platforms will 18 // This class represents the basic information for a native mode. Platforms will
19 // extend this class to add platform specific information about the mode. 19 // extend this class to add platform specific information about the mode.
20 class DISPLAY_TYPES_EXPORT DisplayMode { 20 class DISPLAY_TYPES_EXPORT DisplayMode {
21 public: 21 public:
22 DisplayMode(const gfx::Size& size, bool interlaced, float refresh_rate); 22 DisplayMode(const gfx::Size& size, bool interlaced, float refresh_rate);
23 DisplayMode(DisplayMode&&) = default;
kylechar 2017/01/24 21:15:07 Move to cc file.
thanhph1 2017/01/25 16:26:17 Done.
24 DisplayMode& operator=(DisplayMode&&) = default;
kylechar 2017/01/24 21:15:07 Move to cc file.
thanhph1 2017/01/25 16:26:17 Done.
25
23 virtual ~DisplayMode(); 26 virtual ~DisplayMode();
24 virtual std::unique_ptr<DisplayMode> Clone() const; 27 virtual std::unique_ptr<DisplayMode> Clone() const;
25 28
29 void set_size(const gfx::Size& size) {
kylechar 2017/01/24 21:15:07 We really don't want to make DisplayMode mutable.
thanhph1 2017/01/25 16:26:17 As discussed, I removed display_mode_mojo.(cc|h) a
30 size_ = size;
31 }
32
33 void set_is_interlaced(const bool is_interlaced) {
34 is_interlaced_ = is_interlaced;
35 }
36
37 void set_refresh_rate(const float refresh_rate) {
38 refresh_rate_ = refresh_rate;
39 }
40
26 const gfx::Size& size() const { return size_; } 41 const gfx::Size& size() const { return size_; }
27 bool is_interlaced() const { return is_interlaced_; } 42 bool is_interlaced() const { return is_interlaced_; }
28 float refresh_rate() const { return refresh_rate_; } 43 float refresh_rate() const { return refresh_rate_; }
29 44
30 virtual std::string ToString() const; 45 virtual std::string ToString() const;
31 46
32 private: 47 private:
33 gfx::Size size_; 48 gfx::Size size_;
34 bool is_interlaced_; 49 bool is_interlaced_;
35 float refresh_rate_; 50 float refresh_rate_;
36 51
37 DISALLOW_COPY_AND_ASSIGN(DisplayMode); 52 DISALLOW_COPY_AND_ASSIGN(DisplayMode);
38 }; 53 };
39 54
40 // Used to by gtest to print readable errors. 55 // Used to by gtest to print readable errors.
41 DISPLAY_TYPES_EXPORT void PrintTo(const DisplayMode& mode, std::ostream* os); 56 DISPLAY_TYPES_EXPORT void PrintTo(const DisplayMode& mode, std::ostream* os);
42 57
43 } // namespace display 58 } // namespace display
44 59
45 #endif // UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 60 #endif // UI_DISPLAY_TYPES_DISPLAY_MODE_H_
OLDNEW
« ui/display/mojo/display_struct_traits_unittest.cc ('K') | « ui/display/mojo/typemaps.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698