ui/ozone/common/mojo/display_mode_proxy_test.mojom - Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/common/mojo/display_mode_proxy_test.mojom

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)

Patch Set: convert mojo type to ui::DisplayMode_Params instead. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module ui.mojom;

	6

	7 import "ui/ozone/common/mojo/display_mode_proxy.mojom";

	8

	9 interface DisplayModeProxyTest {
	kylechar 2017/01/17 17:19:27 You'll want to use the same test interface for Dis You'll want to use the same test interface for DisplaySnapshotParams and maybe others, so the name should be more general.
	10 [Sync]

	11 BounceDisplayModeProxy(DisplayModeProxy in) => (DisplayModeProxy out);
	kylechar 2017/01/17 17:19:27 This should be EchoDisplayModeParams. It looks lik This should be EchoDisplayModeParams. It looks like one test uses "BounceStructName" but many tests uses "EchoStructName", so go with the more common usage.
	12 };

OLD	NEW