Create mojom and StructTraits for ui/display/types/display_mode.cc

ui/ozone/common/mojo/display_mode_proxy_struct_traits.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_OZONE_COMMON_MOJO_DISPLAY_MODE_PROXY_STRUCT_TRAITS_H_
+#define UI_OZONE_COMMON_MOJO_DISPLAY_MODE_PROXY_STRUCT_TRAITS_H_
+
+#include "base/logging.h"

[kylechar, 2017/01/17 17:19:26]

I don't think this is used.

[thanhph1, 2017/01/17 20:19:05]

Done.

+#include "ui/ozone/common/gpu/ozone_gpu_message_params.h"
+

[kylechar, 2017/01/17 17:19:27]

You have no #include that contains mojom::DisplayModeProxyDataView or for the
gfx::Size StructTrait definition.

[thanhph1, 2017/01/17 20:19:05]

Done.

+namespace mojo {
+
+template <>
+struct StructTraits<ui::mojom::DisplayModeProxyDataView,
+                    ui::DisplayMode_Params> {
+  static const gfx::Size& size(const ui::DisplayMode_Params& d) {

[kylechar, 2017/01/17 17:19:26]

I would call the parameter |mode| or |display_mode| for clarity, here and in the
two methods below.

[thanhph1, 2017/01/17 20:19:05]

Done.

+    return d.size;
+  }

[kylechar, 2017/01/17 17:19:26]

Whitespace between methods.

[thanhph1, 2017/01/17 20:19:05]

Done.

+  static bool is_interlaced(const ui::DisplayMode_Params& d) {
+    return d.is_interlaced;
+  }
+  static float refresh_rate(const ui::DisplayMode_Params& d) {
+    return d.refresh_rate;
+  }
+
+  static bool Read(ui::mojom::DisplayModeProxyDataView data,
+                   ui::DisplayMode_Params* out) {
+    if (data.is_null())

[kylechar, 2017/01/17 17:19:27]

You shouldn't need this check.

[thanhph1, 2017/01/17 20:19:05]

Done.

+      return false;
+
+    if (!data.ReadSize(&out->size))
+      return false;
+
+    out->is_interlaced = data.is_interlaced();
+    out->refresh_rate = data.refresh_rate();
+
+    return true;
+  }
+};
+
+}  // namespace mojo
+
+#endif  // UI_OZONE_COMMON_MOJO_DISPLAY_MODE_PROXY_STRUCT_TRAITS_H_