ui/ozone/common/mojo/display_mode_proxy.mojom - Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/common/mojo/display_mode_proxy.mojom

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)

Patch Set: convert mojo type to ui::DisplayMode_Params instead. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 module ui.mojom;
	kylechar 2017/01/17 17:19:26 You are missing a copyright string. You are missing a copyright string. thanhph1 2017/01/17 20:19:05 Done. Show quoted text On 2017/01/17 17:19:26, kylechar wrote: > You are missing a copyright string. Done.
	2

	3 import "ui/gfx/geometry/mojo/geometry.mojom";

	4

	5 // Corresponds to ui::DisplayMode_Params

	6 struct DisplayModeProxy {
	kylechar 2017/01/17 17:19:26 This struct should be named DisplayModeParams. Als This struct should be named DisplayModeParams. Also, the filename should change. thanhph1 2017/01/17 20:19:05 Done, I also renamed related files/ dependencies. Show quoted text On 2017/01/17 17:19:26, kylechar wrote: > This struct should be named DisplayModeParams. Also, the filename should change. Done, I also renamed related files/ dependencies.
	7 gfx.mojom.Size size;

	8 bool is_interlaced;

	9 float refresh_rate;

	10 };

OLD	NEW