ui/ozone/common/mojo/BUILD.gn - Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/common/mojo/BUILD.gn

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)

Patch Set: convert mojo type to ui::DisplayMode_Params instead. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.
	kylechar 2017/01/17 17:19:26 2017 2017 thanhph1 2017/01/17 20:19:05 Done. Show quoted text On 2017/01/17 17:19:26, kylechar wrote: > 2017 Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//mojo/public/tools/bindings/mojom.gni")

	6

	7 mojom("ui_ozone_common_mojom_display_mode_proxy") {
	kylechar 2017/01/17 17:19:26 This name is too long and not accurate. You'll be This name is too long and not accurate. You'll be building StructTraits for multiple classes and you don't need the full hierarchy. The name "interfaces" would probably be best since it's widely used elsewhere. thanhph1 2017/01/17 20:19:05 Done, thanks! Show quoted text On 2017/01/17 17:19:26, kylechar wrote: > This name is too long and not accurate. You'll be building StructTraits for > multiple classes and you don't need the full hierarchy. > > The name "interfaces" would probably be best since it's widely used elsewhere. Done, thanks!
	8 sources = [

	9 "display_mode_proxy.mojom",

	10 ]

	11

	12 public_deps = [

	13 "//ui/gfx/geometry/mojo",

	14 ]

	15 }

	16

	17 mojom("test_ui_ozone_common_mojom_display_mode_proxy") {
	kylechar 2017/01/17 17:19:26 mojom("test_interfaces") mojom("test_interfaces") thanhph1 2017/01/17 20:19:05 Done. Show quoted text On 2017/01/17 17:19:26, kylechar wrote: > mojom("test_interfaces") Done.
	18 sources = [

	19 "display_mode_proxy_test.mojom",

	20 ]

	21

	22 public_deps = [

	23 ":ui_ozone_common_mojom_display_mode_proxy",

	24 ]

	25 }

OLD	NEW

« ui/ozone/BUILD.gn ('K') | « ui/ozone/common/BUILD.gn ('k') | ui/ozone/common/mojo/DEPS » ('j') | ui/ozone/common/mojo/display_mode_proxy.mojom » ('J')