third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp - Issue 2636043002: Revert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

Issue 2636043002: Revert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) (Closed)

Patch Set: Remove command source in ApplyStyleCommandTest.cpp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

index 7eb43fef525ea114153f3faa311a43dad6fa53cd..3624499beb95d8747140ae69d0efd909d5174165 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

@@ -47,8 +47,7 @@ TEST_F(ReplaceSelectionCommandTest, pastingEmptySpan) {

ReplaceSelectionCommand* command =

ReplaceSelectionCommand::create(document(), fragment, options);

- EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))

- << "the replace command should have succeeded";

+ EXPECT_TRUE(command->apply()) << "the replace command should have succeeded";

EXPECT_EQ("foo", document().body()->innerHTML()) << "no DOM tree mutation";

}

@@ -71,8 +70,7 @@ TEST_F(ReplaceSelectionCommandTest, pasteSpanInText) {

ReplaceSelectionCommand* command =

ReplaceSelectionCommand::create(document(), fragment, options);

- EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))

- << "the replace command should have succeeded";

+ EXPECT_TRUE(command->apply()) << "the replace command should have succeeded";

EXPECT_EQ("<b>t</b>bar<b>ext</b>", document().body()->innerHTML())

<< "'bar' should have been inserted";

}

@@ -95,8 +93,7 @@ TEST_F(ReplaceSelectionCommandTest, styleTagsInPastedHeadIncludedInContent) {

ReplaceSelectionCommand::CommandOptions options = 0;

ReplaceSelectionCommand* command =

ReplaceSelectionCommand::create(document(), fragment, options);

- EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))

- << "the replace command should have succeeded";

+ EXPECT_TRUE(command->apply()) << "the replace command should have succeeded";

EXPECT_EQ(

"<head><style>foo { bar: baz; }</style></head>"