[Autofill and payments] Redesign Autofill settings UIs

chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
new file mode 100644
index 0000000000000000000000000000000000000000..ab3b71e16c0b25094ed277c6b37be468da0bc5db
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
@@ -0,0 +1,90 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.autofill;
+
+import android.graphics.PorterDuff;
+import android.graphics.drawable.Drawable;
+import android.os.Bundle;
+import android.preference.Preference;
+import android.preference.PreferenceFragment;
+
+import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.autofill.PersonalDataManager;
+import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
+
+/**
+ * Autofill credit cards fragment, which allows the user to edit credit cards.
+ */
+public class AutofillCreditCardsFragment
+        extends PreferenceFragment implements PersonalDataManager.PersonalDataManagerObserver {
+    @Override
+    public void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+        addPreferencesFromResource(R.xml.autofill_and_payments_preference_fragment_screen);
+        getActivity().setTitle(R.string.autofill_credit_cards_title);
+    }
+
+    @Override
+    public void onResume() {
+        super.onResume();
+        // Always rebuild our list of credit cards.  Although we could detect if credit cards are
+        // added or deleted, the credit card summary (number) might be different.  To be safe, we
+        // update all.
+        rebuildCreditCardList();
+    }
+
+    private void rebuildCreditCardList() {
+        getPreferenceScreen().removeAll();
+        getPreferenceScreen().setOrderingAsAdded(true);
+
+        for (CreditCard card : PersonalDataManager.getInstance().getCreditCardsForSettings()) {
+            // Add an item on the current page...

[gone, 2017/01/23 21:26:17]

Comment's not useful and shouldn't end with an ellipsis.  Does this add a
preference for each credit card?  Should the comment say that instead?

[gogerald1, 2017/01/23 22:04:18]

Done.

+            Preference pref = new Preference(getActivity());
+            pref.setTitle(card.getObfuscatedNumber());
+            pref.setSummary(card.getFormattedExpirationDate(getActivity()));
+            pref.setIcon(card.getIssuerIconDrawableId());
+
+            if (card.getIsLocal()) {
+                pref.setFragment(AutofillLocalCardEditor.class.getName());
+            } else {
+                pref.setFragment(AutofillServerCardEditor.class.getName());
+                pref.setWidgetLayoutResource(R.layout.autofill_server_data_label);
+            }
+
+            Bundle args = pref.getExtras();
+            args.putString(AutofillAndPaymentsPreferences.AUTOFILL_GUID, card.getGUID());
+            getPreferenceScreen().addPreference(pref);
+        }
+
+        Preference pref = new Preference(getActivity());

[gone, 2017/01/23 21:26:17]

Add a comment about what this block does.  Looks like it's setting up the "Add
new credit card" button.

[gogerald1, 2017/01/23 22:04:18]

Done.

+        Drawable plusIcon = ApiCompatibilityUtils.getDrawable(getResources(), R.drawable.plus);
+        plusIcon.mutate();
+        plusIcon.setColorFilter(
+                ApiCompatibilityUtils.getColor(getResources(), R.color.pref_accent_color),
+                PorterDuff.Mode.SRC_IN);
+        pref.setIcon(plusIcon);
+        pref.setTitle(R.string.autofill_create_credit_card);
+        pref.setFragment(AutofillLocalCardEditor.class.getName());
+        getPreferenceScreen().addPreference(pref);
+    }
+
+    @Override
+    public void onPersonalDataChanged() {
+        rebuildCreditCardList();
+    }
+
+    @Override
+    public void onActivityCreated(Bundle savedInstanceState) {
+        super.onActivityCreated(savedInstanceState);
+        PersonalDataManager.getInstance().registerDataObserver(this);
+    }
+
+    @Override
+    public void onDestroyView() {
+        PersonalDataManager.getInstance().unregisterDataObserver(this);
+        super.onDestroyView();
+    }
+}