Disable browser key reservation in fullscreen mode

chrome/browser/ui/browser_command_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_command_controller.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 181 matching lines @@
   // reserve browser back/forward and refresh here.
   ui::KeyboardCode key_code =
     static_cast<ui::KeyboardCode>(event.windowsKeyCode);
   if ((key_code == ui::VKEY_BROWSER_BACK && command_id == IDC_BACK) ||
       (key_code == ui::VKEY_BROWSER_FORWARD && command_id == IDC_FORWARD) ||
       (key_code == ui::VKEY_BROWSER_REFRESH && command_id == IDC_RELOAD)) {
     return true;
   }
 #endif
 
-  if (window()->IsFullscreen() && command_id == IDC_FULLSCREEN)
-    return true;
+  if (window()->IsFullscreen()) {
+    // In full-screen mode, all the keys, except for F11, should be delivered to
+    // the web page. This has been discussed in the document Allowing sites to

[dominickn, 2017/01/16 22:13:39]

Since this is a web-facing change, this cannot be landed until an intent to
implement and ship is posted to blink-dev and approved. I think garykac@ is in
charge of that.

When it's been posted and approved, this CL should link to the blink-dev
discussion, not to an internal doc.

A test should also be added for the changes in this method, probably in
browser_command_controller_unittest.cc

[Hzj_jie, 2017/01/17 23:19:10]

I have received the intent of implementation from Gary, since it's not still in
discussion stage, I will update it once it is approved.

+    // intercept keyboard shortcuts at https://goo.gl/r6XmNt.
+    return command_id == IDC_FULLSCREEN;
+  }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // If this key was registered by the user as a content editing hotkey, then
   // it is not reserved.
   ui::TextEditKeyBindingsDelegateAuraLinux* delegate =
       ui::GetTextEditKeyBindingsDelegate();
   if (delegate && event.os_event && delegate->MatchEvent(*event.os_event, NULL))
     return false;
 #endif
 
@@ skipping 959 matching lines @@
 
 BrowserWindow* BrowserCommandController::window() {
   return browser_->window();
 }
 
 Profile* BrowserCommandController::profile() {
   return browser_->profile();
 }
 
 }  // namespace chrome