Not able to set width using ColGroup in the table.

Not able to set width using ColGroup in the table.

We ignored a col / colgroup that were not present at the start of the table
for the purpose of layout.

Other browsers would take into account the col / colgroup anywhere in the table
so this change makes us match them.

The 2 new baselines are progressions (as in we match other browsers)

R=jchaffraix@chromium.org
BUG=305169
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159442

[Julien - ping for review, 2013-10-08 18:46:57]

To be frank, this is a dumb use case and I am not convinced it's worth allowing
it (especially since crbug doesn't show any bug for that apart from your
artificial one). That said, other browsers allow it so lgtm :(

Now some comments on the description:

"Column group width was not applied to column because we was supporting only
if column group present at the start in table."

we was -> we were
I think it would be more readable to write: We ignored a col / colgroup that
were not present at the start of the table for the purpose of layout. 

"But Firefox and IE applied column group width to the column no matter where
colGroup is present in the table. Same is applied here."

Other browsers would take into account the col / colgroup anywhere in the table
so this change makes us match them.

"This patch is fixing 2 regressions also."

Regression from what? I think you are saying it backwards: the 2 new baselines
are progressions (as in we match other browsers)

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
File LayoutTests/fast/table/table-colgroup-present-after-table-row.html (right):

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
LayoutTests/fast/table/table-colgroup-present-after-table-row.html:4:
<title>Table ColGroup</title>
Title are not really useful in LayoutTests (it is not dumped in the output).

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
LayoutTests/fast/table/table-colgroup-present-after-table-row.html:11: <h3>Test
for chromium bug : <a
href="https://code.google.com/p/chromium/issues/detail?id=305169">305169</a>.
Not able to set width using ColGroup in the table.</h3>
The bug title should be: "<colgroup> is ignored if seen after <tr>."

[commit-bot: I haz the power, 2013-10-11 08:33:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.suchit@samsung.com/26360003/6001

[a.suchit, 2013-10-11 09:01:26]

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
File LayoutTests/fast/table/table-colgroup-present-after-table-row.html (right):

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
LayoutTests/fast/table/table-colgroup-present-after-table-row.html:4:
<title>Table ColGroup</title>
On 2013/10/08 18:46:57, Julien Chaffraix wrote:
> Title are not really useful in LayoutTests (it is not dumped in the output).

Done.

https://codereview.chromium.org/26360003/diff/1/LayoutTests/fast/table/table-...
LayoutTests/fast/table/table-colgroup-present-after-table-row.html:11: <h3>Test
for chromium bug : <a
href="https://code.google.com/p/chromium/issues/detail?id=305169">305169</a>.
Not able to set width using ColGroup in the table.</h3>
On 2013/10/08 18:46:57, Julien Chaffraix wrote:
> The bug title should be: "<colgroup> is ignored if seen after <tr>."

Done.

[commit-bot: I haz the power, 2013-10-11 10:21:47]

Change committed as 159442