Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2635993002: 📰 Reset the view for items that stop being dismissable (Closed)
Patch Set: Move callback to recyclerview Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
index dbcb00b36c74c38f6d04175376d1278653efa1ae..d3ff538eb437e0afc9283c9dcb12a363c8c17959 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
@@ -56,6 +56,14 @@
private static final int PEEKING_CARD_ANIMATION_TIME_MS = 1000;
private static final int PEEKING_CARD_ANIMATION_START_DELAY_MS = 300;
+ /**
+ * A single instance of {@link ResetForDismissCallback} that can be reused as it has no
+ * state.
+ */
+ public static final NewTabPageViewHolder.PartialBindCallback RESET_FOR_DISMISS_CALLBACK =
+ new ResetForDismissCallback();
+
+
private final GestureDetector mGestureDetector;
private final LinearLayoutManager mLayoutManager;
@@ -705,4 +713,15 @@ public void onChildDraw(Canvas c, RecyclerView recyclerView, ViewHolder viewHold
}
return viewHolders;
}
+
+ /**
+ * Callback to reset a card's properties affected by swipe to dismiss.
+ */
+ private static class ResetForDismissCallback extends NewTabPageViewHolder.PartialBindCallback {
+ @Override
+ public void onResult(NewTabPageViewHolder holder) {
+ assert holder instanceof CardViewHolder;
+ ((CardViewHolder) holder).getRecyclerView().updateViewStateForDismiss(0, holder);
+ }
+ }
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698