Final cleanup pass over audio device API

extensions/browser/api/audio/audio_service.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_AUDIO_AUDIO_SERVICE_H_
 #define EXTENSIONS_BROWSER_API_AUDIO_AUDIO_SERVICE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 35 matching lines @@
 
   virtual ~AudioService() {}
 
   // Called by listeners to this service to add/remove themselves as observers.
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Start to query audio device information. Should be called on UI thread.
   // Populates |output_info_out| and |input_info_out| with the results.
   // Returns true on success.
+  // DEPRECATED: Use |GetDevices| instead.
   virtual bool GetInfo(OutputInfo* output_info_out,
                        InputInfo* input_info_out) = 0;
 
+  // Retrieves list of audio devices that satisfy |filter|. Poulates

[jennyz, 2017/02/02 01:10:44]

typo: Poulates -> Populates

[tbarzic, 2017/02/02 01:24:41]

Done.

+  // |devices_out| with retrieved devices.
+  // If |filter->is_active| is set, |devices_out| will contain only devices
+  // whose is-active state matches |filter->is_active| value.
+  // If |filter->stream_types| is set, |devices_out| will contain only devices
+  // whose stream type (INPUT for input devices, OUTPUT for output devices) is
+  // contained in |filter->stream_types|.
+  // Returns whether the list of devices was successfully retrieved.
+  virtual bool GetDevices(const api::audio::DeviceFilter& filter,
+                          DeviceInfoList* devices_out) = 0;
+
   // Sets set of active inputs to devices defined by IDs in |input_devices|,
   // and set of active outputs to devices defined by IDs in |output_devices|.
   // If either of |input_devices| or |output_devices| is not set, associated
   // set of active devices will remain unchanged.
   // If either list is empty, all active devices of associated type will be
   // deactivated.
   // Returns whether the operation succeeded - on failure there will be no
   // changes to active devices.
   // Note that device ID lists should contain only existing device ID of
   // appropriate type in order for the method to succeed.
@@ skipping 32 matching lines @@
  protected:
   AudioService() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AudioService);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_AUDIO_AUDIO_SERVICE_H_