Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/code-stubs.cc

Issue 2635973002: [heap] Don't allocate immovable code in LO space during serialization (Closed)
Patch Set: Add test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 UnseededNumberDictionary::AtNumberPut( 186 UnseededNumberDictionary::AtNumberPut(
187 Handle<UnseededNumberDictionary>(heap->code_stubs()), 187 Handle<UnseededNumberDictionary>(heap->code_stubs()),
188 GetKey(), 188 GetKey(),
189 new_object); 189 new_object);
190 heap->SetRootCodeStubs(*dict); 190 heap->SetRootCodeStubs(*dict);
191 } 191 }
192 code = *new_object; 192 code = *new_object;
193 } 193 }
194 194
195 Activate(code); 195 Activate(code);
196 DCHECK(!NeedsImmovableCode() || 196 DCHECK(!NeedsImmovableCode() || Heap::IsImmovable(code) ||
197 heap->lo_space()->Contains(code) ||
198 heap->code_space()->FirstPage()->Contains(code->address())); 197 heap->code_space()->FirstPage()->Contains(code->address()));
199 return Handle<Code>(code, isolate()); 198 return Handle<Code>(code, isolate());
200 } 199 }
201 200
202 201
203 const char* CodeStub::MajorName(CodeStub::Major major_key) { 202 const char* CodeStub::MajorName(CodeStub::Major major_key) {
204 switch (major_key) { 203 switch (major_key) {
205 #define DEF_CASE(name) case name: return #name "Stub"; 204 #define DEF_CASE(name) case name: return #name "Stub";
206 CODE_STUB_LIST(DEF_CASE) 205 CODE_STUB_LIST(DEF_CASE)
207 #undef DEF_CASE 206 #undef DEF_CASE
(...skipping 2001 matching lines...) Expand 10 before | Expand all | Expand 10 after
2209 } 2208 }
2210 2209
2211 ArrayConstructorStub::ArrayConstructorStub(Isolate* isolate) 2210 ArrayConstructorStub::ArrayConstructorStub(Isolate* isolate)
2212 : PlatformCodeStub(isolate) {} 2211 : PlatformCodeStub(isolate) {}
2213 2212
2214 InternalArrayConstructorStub::InternalArrayConstructorStub(Isolate* isolate) 2213 InternalArrayConstructorStub::InternalArrayConstructorStub(Isolate* isolate)
2215 : PlatformCodeStub(isolate) {} 2214 : PlatformCodeStub(isolate) {}
2216 2215
2217 } // namespace internal 2216 } // namespace internal
2218 } // namespace v8 2217 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698