chrome/install_static/initialize_from_primary_module.h - Issue 2635953002: Use loader-based binding of GetInstallDetailsPayload for install_static.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/install_static/initialize_from_primary_module.h

Issue 2635953002: Use loader-based binding of GetInstallDetailsPayload for install_static. (Closed)

Patch Set: better Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALL_STATIC_INITIALIZE_FROM_PRIMARY_MODULE_H_

	6 #define CHROME_INSTALL_STATIC_INITIALIZE_FROM_PRIMARY_MODULE_H_

	7

	8 namespace install_static {

	9

	10 // Initializes an InstallDetails instance for this module with the payload from

	11 // the process's primary module (which exports an "GetInstallDetailsPayload"

	12 // function for this express purpose).
	Sigurður Ásgeirsson 2017/01/16 18:31:58 doesn't this need to be in an extern "C" declarati doesn't this need to be in an extern "C" declaration for linking to work? grt (UTC plus 2) 2017/01/16 20:27:33 This function isn't used across DLL boundaries. It Show quoted text On 2017/01/16 18:31:58, Sigurður Ásgeirsson wrote: > doesn't this need to be in an extern "C" declaration for linking to work? This function isn't used across DLL boundaries. It is a helper used by "secondary" modules (i.e., chrome.exe, chrome.dll, chrome_watcher.dll, and chrome_child.dll) which calls into the fn exported by the "primary" module (i.e., chrome_elf).
	13 void InitializeFromPrimaryModule();

	14

	15 } // namespace install_static

	16

	17 #endif // CHROME_INSTALL_STATIC_INITIALIZE_FROM_PRIMARY_MODULE_H_

OLD	NEW