[ast] Remove internalization before AST rewriting

src/assert-scope.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/assert-scope.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/base/platform/platform.h"
 #include "src/debug/debug.h"
 #include "src/isolate.h"
@@ skipping 65 matching lines @@
     PerThreadAssertData::SetCurrent(data_);
   }
   data_->IncrementLevel();
   old_state_ = data_->Get(kType);
   data_->Set(kType, kAllow);
 }
 
 
 template <PerThreadAssertType kType, bool kAllow>
 PerThreadAssertScope<kType, kAllow>::~PerThreadAssertScope() {
-  DCHECK_NOT_NULL(data_);
+  if (data_ == nullptr) return;
   data_->Set(kType, old_state_);
   if (data_->DecrementLevel()) {
     PerThreadAssertData::SetCurrent(NULL);
     delete data_;
   }

[rmcilroy, 2017/01/17 10:41:31]

Could you just call Release here rather than duplicating code?

[Leszek Swirski, 2017/01/17 12:11:49]

Not directly, because of the DCHECK, but extracted out into a common function.

[Leszek Swirski, 2017/01/17 12:17:18]

Ignore me, I'm an idiot. Done.

 }
 
+template <PerThreadAssertType kType, bool kAllow>
+void PerThreadAssertScope<kType, kAllow>::Release() {
+  DCHECK_NOT_NULL(data_);
+  data_->Set(kType, old_state_);
+  if (data_->DecrementLevel()) {
+    PerThreadAssertData::SetCurrent(NULL);
+    delete data_;
+  }
+  data_ = nullptr;
+}
 
 // static
 template <PerThreadAssertType kType, bool kAllow>
 bool PerThreadAssertScope<kType, kAllow>::IsAllowed() {
   PerThreadAssertData* data = PerThreadAssertData::GetCurrent();
   return data == NULL || data->Get(kType);
 }
 
 
 template <PerIsolateAssertType kType, bool kAllow>
@@ skipping 41 matching lines @@
 template class PerIsolateAssertScope<JAVASCRIPT_EXECUTION_ASSERT, true>;
 template class PerIsolateAssertScope<JAVASCRIPT_EXECUTION_THROWS, false>;
 template class PerIsolateAssertScope<JAVASCRIPT_EXECUTION_THROWS, true>;
 template class PerIsolateAssertScope<DEOPTIMIZATION_ASSERT, false>;
 template class PerIsolateAssertScope<DEOPTIMIZATION_ASSERT, true>;
 template class PerIsolateAssertScope<COMPILATION_ASSERT, false>;
 template class PerIsolateAssertScope<COMPILATION_ASSERT, true>;
 
 }  // namespace internal
 }  // namespace v8