Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 26359003: Adding "UserAddedToSession" notifier to the SessionStateObserver (Closed)

Created:
7 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Adding "UserAddedToSession" notifier to the SessionStateObserver As discussed - there is no way to figure out that a user got added to the session. The UI needs to adapt to new users by presenting them dynamically in the system shelf menu (and possibly other places). This CL is adding this observer functionality accordingly. BUG=305433 TEST=manual testing by adding functions to various existing observer to see if they fire upon adding user. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ash/session_state_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mr4D (OOO till 08-26)
Please have a look! (Added Oshima as owner)
7 years, 2 months ago (2013-10-09 14:32:12 UTC) #1
Dmitry Polukhin
lgtm
7 years, 2 months ago (2013-10-09 15:43:07 UTC) #2
oshima
lgtm
7 years, 2 months ago (2013-10-09 16:39:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/26359003/1
7 years, 2 months ago (2013-10-09 16:41:38 UTC) #4
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=110751
7 years, 2 months ago (2013-10-09 17:59:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/26359003/1
7 years, 2 months ago (2013-10-09 19:54:38 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 21:01:39 UTC) #7
Message was sent while issue was closed.
Change committed as 227806

Powered by Google App Engine
This is Rietveld 408576698