Reland: Do not initialize v8::Context on |ScriptController::updateDocument|.

Source/bindings/v8/ScriptController.cpp

Index: Source/bindings/v8/ScriptController.cpp
diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp
index 62146cf8e3f97726693078c9903832c0800bc74f..94c3f76179d258e4aa7d1d35c422b619a6aead6f 100644
--- a/Source/bindings/v8/ScriptController.cpp
+++ b/Source/bindings/v8/ScriptController.cpp
@@ -473,8 +473,8 @@ int ScriptController::contextDebugId(v8::Handle<v8::Context> context)
 
 void ScriptController::updateDocument()
 {
-    // For an uninitialized main window shell, do not incur the cost of context initialization during FrameLoader::init().
-    if ((!m_windowShell->isContextInitialized() || !m_windowShell->isGlobalInitialized()) && m_frame->loader().stateMachine()->creatingInitialEmptyDocument())
+    // For an uninitialized main window shell, do not incur the cost of context initialization.
+    if (!m_windowShell->isContextInitialized() || !m_windowShell->isGlobalInitialized() || m_frame->loader().stateMachine()->creatingInitialEmptyDocument())

[dcarney, 2014/04/30 07:01:13]

is it possible that the third condition is enough here?

[kouhei (in TOK), 2014/04/30 07:04:53]

No. In this patch, we want to avoid creating windowshell when loading html
without Javascript. It is not necessary an InitialEmptyDocument().

For simplifying, we may be able to drop the third condition instead.
!m_windowShell->isContextInitialized() should always hold when
m_frame->loader().stateMachine()->creatingInitialEmptyDocument().

[dcarney, 2014/04/30 07:11:49]

 Ok, I see what you mean.  I remember needing it when I put it there, but I'm no
longer sure why.   I'm not sure anymore why the second one is there.  It doesn't
look right.  Maybe the first condition is sufficient if the other two are
removed?

[kouhei (in TOK), 2014/04/30 07:25:44]

I think this should be 'if (!m_windowShell->isGlobalInitialized())". It is
possible that global w/ document property is still there while context is lost.

         return;
 
     if (!initializeMainWorld())