Source/bindings/v8/ScriptController.cpp - Issue 263583002: Reland: Do not initialize v8::Context on |ScriptController::updateDocument|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 263583002: Reland: Do not initialize v8::Context on |ScriptController::updateDocument|. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/ScriptController.cpp

diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp

index 62146cf8e3f97726693078c9903832c0800bc74f..971461eaec32533f608b1ad44a6335f9a454ac41 100644

--- a/Source/bindings/v8/ScriptController.cpp

+++ b/Source/bindings/v8/ScriptController.cpp

@@ -474,7 +474,7 @@ int ScriptController::contextDebugId(v8::Handle<v8::Context> context)

void ScriptController::updateDocument()

{

// For an uninitialized main window shell, do not incur the cost of context initialization during FrameLoader::init().

jochen (gone - plz use gerrit) 2014/04/30 04:37:18 the comment is no longer correct

kouhei (in TOK) 2014/04/30 06:13:30 Done.

- if ((!m_windowShell->isContextInitialized() || !m_windowShell->isGlobalInitialized()) && m_frame->loader().stateMachine()->creatingInitialEmptyDocument())

+ if (!m_windowShell->isContextInitialized() || !m_windowShell->isGlobalInitialized() || m_frame->loader().stateMachine()->creatingInitialEmptyDocument())

return;

if (!initializeMainWorld())

« no previous file with comments | « no previous file | no next file » | no next file with comments »