Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: build/android/adb_profile_chrome.py

Issue 26358012: Use CategoryFilter::kDefaultCategoryFilterString instead of "*" as the default category (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/tracing_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_profile_chrome.py
diff --git a/build/android/adb_profile_chrome.py b/build/android/adb_profile_chrome.py
index ba5b1ed554340a1c88aa46f925d0b38fd75732a5..a8b1eac5038cbfaf9ed21fc6e88c67fddb586314 100755
--- a/build/android/adb_profile_chrome.py
+++ b/build/android/adb_profile_chrome.py
@@ -34,7 +34,7 @@ def _GetSupportedBrowsers():
def _StartTracing(adb, package_info, categories, continuous):
adb.BroadcastIntent(package_info.package, 'GPU_PROFILER_START',
- '-e categories "%s"' % categories,
+ '-e categories "%s"' % categories if categories else '',
'-e continuous' if continuous else '')
@@ -131,7 +131,7 @@ def _CaptureAndDownloadTimedTrace(adb, package_info, categories, interval,
def _ComputeCategories(options):
- categories = [options.categories]
+ categories = [options.categories] if options.categories else []
if options.trace_cc:
categories.append('disabled-by-default-cc.debug*')
if options.trace_gpu:
@@ -163,7 +163,7 @@ def main():
categories = optparse.OptionGroup(parser, 'Trace categories')
categories.add_option('-c', '--categories', help='Select categories to trace '
'with comma-delimited wildcards, e.g., '
- '"*", "cat1*,-cat1a". Default is "*".', default='*')
+ '"*", "cat1*,-cat1a".')
Sami 2013/10/14 11:22:19 Having an emptry string imply default categories i
Xianzhu 2013/10/14 16:44:40 Do you mean '--categories ""' to opt-out chromium
categories.add_option('--trace-cc', help='Enable extra trace categories for '
'compositor frame viewer data.', action='store_true')
categories.add_option('--trace-gpu', help='Enable extra trace categories for '
« no previous file with comments | « no previous file | content/browser/android/tracing_controller_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698