Chromium Code Reviews| Index: build/android/adb_profile_chrome.py |
| diff --git a/build/android/adb_profile_chrome.py b/build/android/adb_profile_chrome.py |
| index ba5b1ed554340a1c88aa46f925d0b38fd75732a5..a8b1eac5038cbfaf9ed21fc6e88c67fddb586314 100755 |
| --- a/build/android/adb_profile_chrome.py |
| +++ b/build/android/adb_profile_chrome.py |
| @@ -34,7 +34,7 @@ def _GetSupportedBrowsers(): |
| def _StartTracing(adb, package_info, categories, continuous): |
| adb.BroadcastIntent(package_info.package, 'GPU_PROFILER_START', |
| - '-e categories "%s"' % categories, |
| + '-e categories "%s"' % categories if categories else '', |
| '-e continuous' if continuous else '') |
| @@ -131,7 +131,7 @@ def _CaptureAndDownloadTimedTrace(adb, package_info, categories, interval, |
| def _ComputeCategories(options): |
| - categories = [options.categories] |
| + categories = [options.categories] if options.categories else [] |
| if options.trace_cc: |
| categories.append('disabled-by-default-cc.debug*') |
| if options.trace_gpu: |
| @@ -163,7 +163,7 @@ def main(): |
| categories = optparse.OptionGroup(parser, 'Trace categories') |
| categories.add_option('-c', '--categories', help='Select categories to trace ' |
| 'with comma-delimited wildcards, e.g., ' |
| - '"*", "cat1*,-cat1a". Default is "*".', default='*') |
| + '"*", "cat1*,-cat1a".') |
|
Sami
2013/10/14 11:22:19
Having an emptry string imply default categories i
Xianzhu
2013/10/14 16:44:40
Do you mean '--categories ""' to opt-out chromium
|
| categories.add_option('--trace-cc', help='Enable extra trace categories for ' |
| 'compositor frame viewer data.', action='store_true') |
| categories.add_option('--trace-gpu', help='Enable extra trace categories for ' |