[WebView] initial webview-side implementation of safebrowsing

android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java

Index: android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java b/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java
index 52869fbed940a2565a033312521b613ecc8a1f1d..f960eefca6ec1d4be16f19224daddacd8f5b9da9 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java
@@ -7,6 +7,9 @@ package org.chromium.android_webview;
 import android.content.Context;
 import android.content.SharedPreferences;
 
+import org.chromium.base.CommandLine;
+import org.chromium.components.safe_browsing.SafeBrowsingApiBridge;
+import org.chromium.components.safe_browsing.SafeBrowsingApiHandler;
 import org.chromium.content.browser.AppWebMessagePortService;
 import org.chromium.content.browser.ContentViewStatics;
 
@@ -19,6 +22,7 @@ import org.chromium.content.browser.ContentViewStatics;
  * AwBrowserContext instance, so at this point the class mostly exists for conceptual clarity.
  */
 public class AwBrowserContext {
+    private static final String TAG = "AwBrowserContext";
     private final SharedPreferences mSharedPreferences;
 
     private AwGeolocationPermissions mGeolocationPermissions;
@@ -30,6 +34,10 @@ public class AwBrowserContext {
     public AwBrowserContext(SharedPreferences sharedPreferences, Context applicationContext) {
         mSharedPreferences = sharedPreferences;
         mApplicationContext = applicationContext;
+
+        if (CommandLine.getInstance().hasSwitch(AwSwitches.WEBVIEW_ENABLE_SAFEBROWSING_SUPPORT)) {
+            initSafeBrowsingApiHandler();
+        }
     }
 
     public AwGeolocationPermissions getGeolocationPermissions() {
@@ -73,4 +81,19 @@ public class AwBrowserContext {
     public void resumeTimers() {
         ContentViewStatics.setWebKitSharedTimersSuspended(false);
     }
+
+    @SuppressWarnings("unchecked")
+    private void initSafeBrowsingApiHandler() {

[paulmiller, 2017/01/17 21:45:01]

Wouldn't you rather use PlatformServiceBridge for this? The idea with
PlatformServiceBridge was that it'd be a generic way to connect to closed GMS
code, which would keep the reflection ugliness isolated. (That's why we picked
such a vague name.) This logic seems redundant.

[sgurun-gerrit only, 2017/01/17 22:59:50]

I think it is not super important, we could do it in a follow up cl if there is
an advantage. Honestly, I don't see an immediate advantage now.

[paulmiller, 2017/01/18 00:58:03]

Come to think of it, PlatformServiceBridge doesn't just encapsulate the
reflection; it also encapsulates the call which allows WebView to use GMS in the
first place (see the downstream constructor). Remember, that's why we decided to
move the call from tryEnableGms to the constructor; so upstream code could just
use GMS through PlatformServiceBridge and not worry about the complexities of
the WebView/GMS interaction. I'll file a bug.

+        final String safeBrowsingApiHandler =
+                "com.android.webview.chromium.AwSafeBrowsingApiHandler";
+
+        // Try to get a specialized service bridge.
+        try {
+            Class<? extends SafeBrowsingApiHandler> cls =
+                    (Class<? extends SafeBrowsingApiHandler>) Class.forName(safeBrowsingApiHandler);
+            SafeBrowsingApiBridge.setSafeBrowingHandlerType(cls);
+        } catch (ClassNotFoundException e) {
+            // This is not an error; it just means this device doesn't have specialized services.
+        }
+    }
 }