[FastTextAutosizer] Remove printing checks from enabled()

[FastTextAutosizer] Remove printing checks from enabled()

This is first of two patches to refactor our enabled() code for
understandability. This patch removes the document->printing() check
from enabled() and refactors updatePageInfo to reduce duplicated code.
When printing is enabled / disabled, updatePageInfo is always called
which is what enables this refactoring. Printing doesn't change often so
there's no reason to check it multiple times for each block :)

Cleanups:
1) enabled() has been merged into shouldHandleLayout() since all callers
always checked both.
2) We had duplicated logic for the two cases when we should reset
multipliers in updatePageInfo. These have been combined and changing
"m_hasAutosized" has been moved out of resetMultipliers and into
updatePageInfo so almost no PageInfo-related state is modified outside
updatePageInfo.
3) Unnecessary calls to m_document->page()->mainFrame() have been
removed in updatePageInfo.

This change is a little messy but I hope it's clear how much of this
will be cleaned up once enabled() goes away. Slimming down enabled()
will be a perf win as well.

BUG=367864
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173020

[skobes, 2014-04-30 18:28:08]

lgtm

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
File LayoutTests/fast/text-autosizing/print-autosizing.html (right):

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
LayoutTests/fast/text-autosizing/print-autosizing.html:16: onload = function() {
I think if you put the <script> at the end below the content, you don't need
onload.

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
LayoutTests/fast/text-autosizing/print-autosizing.html:19:
window.requestAnimationFrame(function() {
(nit) remove unnecessary "window."

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:463: // FIXME(crbug.com/367864):
Unify this with m_pageInfo.m_settingEnabled.
Remove this? Or is there more to address?

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:490: m_pageInfo.m_settingEnabled =
m_document->settings() && m_document->settings()->textAutosizingEnabled();
This could just be

m_pageInfo.m_settingEnabled = enabled();

[pdr., 2014-04-30 18:49:01]

Thanks!

Followup patch coming right up

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
File LayoutTests/fast/text-autosizing/print-autosizing.html (right):

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
LayoutTests/fast/text-autosizing/print-autosizing.html:16: onload = function() {
On 2014/04/30 18:28:08, skobes wrote:
> I think if you put the <script> at the end below the content, you don't need
> onload.

Done.

https://codereview.chromium.org/263563006/diff/1/LayoutTests/fast/text-autosi...
LayoutTests/fast/text-autosizing/print-autosizing.html:19:
window.requestAnimationFrame(function() {
On 2014/04/30 18:28:08, skobes wrote:
> (nit) remove unnecessary "window."

Done.

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:463: // FIXME(crbug.com/367864):
Unify this with m_pageInfo.m_settingEnabled.
On 2014/04/30 18:28:08, skobes wrote:
> Remove this? Or is there more to address?

There's a little more to address: I want to further refactor enabled() (possibly
remove it) in a followup. This patch sets everything up so that patch will be
easy.

https://codereview.chromium.org/263563006/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:490: m_pageInfo.m_settingEnabled =
m_document->settings() && m_document->settings()->textAutosizingEnabled();
On 2014/04/30 18:28:08, skobes wrote:
> This could just be
> 
> m_pageInfo.m_settingEnabled = enabled();

Done.

[pdr., 2014-04-30 18:49:05]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-04-30 18:49:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/263563006/20001

[commit-bot: I haz the power, 2014-04-30 19:51:54]

Change committed as 173020