Add referrer & load flag support to BitmapFetcher class.

Add referrer & load flag support to BitmapFetcher class.

BitmapFetcher only had net::URLRequestContextGetter argument for
fetching. Add referrer, referrer policy, and load flags arguments for more
sophisticated fetching control.

This will be used for downloading salient images background for enhanced
bookmark experiment.

BUG=368034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268802

[Kibeom Kim (inactive), 2014-04-30 00:58:56]

jam@ : One question: ios had ReferrerHeaderUrlForNavigation(..) as an
independent static function, but this functionality is really close to what
Referrer class is for, so I thought moving to Referrer struct(now class) makes
sense, but wasn't sure promoting it to class is fine. Do you think this is ok?

https://codereview.chromium.org/263563003/diff/30001/chrome/browser/bitmap_fe...
File chrome/browser/bitmap_fetcher.cc (right):

https://codereview.chromium.org/263563003/diff/30001/chrome/browser/bitmap_fe...
chrome/browser/bitmap_fetcher.cc:38: url_fetcher_->SetLoadFlags(load_flags);
Similar to ImageFetcher::StartDownload

https://chrome-internal.googlesource.com/bling/chromium/+/master/chrome/commo...

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
File content/public/common/referrer.cc (right):

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
content/public/common/referrer.cc:14: GURL ReferrerForHeader(const GURL&
referrer) {
From ios/web/public/referrer_util.cc .

https://chrome-internal.googlesource.com/bling/chromium/+/master/ios/web/publ...

More context:
https://chromereviews.googleplex.com/6891014
https://chromereviews.googleplex.com/6908014

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
File content/public/common/referrer.h (right):

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
content/public/common/referrer.h:27: // TODO(kkimlabs): Make private, make
getter & setter, and rename, e.g., url_.
I'll do this for the next patchset if making Referrer struct -> class is ok.

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
File content/public/common/referrer_unittest.cc (right):

https://codereview.chromium.org/263563003/diff/30001/content/public/common/re...
content/public/common/referrer_unittest.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
from
https://chrome-internal.googlesource.com/bling/chromium/+/master/ios/web/publ...

[jam, 2014-04-30 16:00:57]

please see the guidelines for the content api:
http://www.chromium.org/developers/content-module/content-api

since this new method is only called from chrome, it should be in src\chrome.

[Kibeom Kim (inactive), 2014-05-05 23:17:13]

+sky
jam->cc (as I removed content/*)

Removed policy handling code, and made it caller's responsibility to correctly
configure |url_fetcher|'s referrer and referrer policy.

[sky, 2014-05-06 00:30:47]

https://codereview.chromium.org/263563003/diff/150001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher.h (right):

https://codereview.chromium.org/263563003/diff/150001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher.h:41: void Start(net::URLRequestContextGetter*
request_context,
Can you convert callers to this new function so there is only one start?

[Kibeom Kim (inactive), 2014-05-06 01:48:51]

https://codereview.chromium.org/263563003/diff/150001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher.h (right):

https://codereview.chromium.org/263563003/diff/150001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher.h:41: void Start(net::URLRequestContextGetter*
request_context,
On 2014/05/06 00:30:47, sky wrote:
> Can you convert callers to this new function so there is only one start?

Done.

[sky, 2014-05-06 15:24:20]

LGTM

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_manager.cc (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_manager.cc:140: "",
""->std::string()

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher.h (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher.h:36: // already in progress.  Arguments are used
to configure the internal fetcher.
Better document what load_flags is. Specifically if I'm going to use this I
don't want to have to look else where for the common case.

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher_browsertest.cc (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher_browsertest.cc:118: "",
""->std::string() here and every where.

[Kibeom Kim (inactive), 2014-05-06 18:07:13]

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_manager.cc (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_manager.cc:140: "",
On 2014/05/06 15:24:20, sky wrote:
> ""->std::string()

Done.

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher.h (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher.h:36: // already in progress.  Arguments are used
to configure the internal fetcher.
On 2014/05/06 15:24:20, sky wrote:
> Better document what load_flags is. Specifically if I'm going to use this I
> don't want to have to look else where for the common case.

Done.

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
File chrome/browser/bitmap_fetcher_browsertest.cc (right):

https://codereview.chromium.org/263563003/diff/170001/chrome/browser/bitmap_f...
chrome/browser/bitmap_fetcher_browsertest.cc:118: "",
On 2014/05/06 15:24:20, sky wrote:
> ""->std::string() here and every where.

Done.

[Kibeom Kim (inactive), 2014-05-06 18:07:19]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-06 18:08:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/263563003/190001

[Kibeom Kim (inactive), 2014-05-06 18:50:14]

The CQ bit was unchecked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2014-05-06 19:02:29]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-06 19:04:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/263563003/230001

[Kibeom Kim (inactive), 2014-05-06 23:46:43]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-06 23:47:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/263563003/250001

[Kibeom Kim (inactive), 2014-05-07 00:14:39]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-07 00:17:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/263563003/270001

[commit-bot: I haz the power, 2014-05-07 06:21:27]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 16:19:42]

Change committed as 268802