Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2635583002: Add UseCounter for setPointerCapture outside dispatch (Closed)
Patch Set: Rebase again Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/input/PointerEventManager.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 1d04ee44151c4d06e3199df240202e27eee051aa..6ca381f5ae8865f0eb3ae0fee7d6c53da41aa57f 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -19,6 +19,7 @@
#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
#include "public/platform/WebTouchEvent.h"
+#include "wtf/AutoReset.h"
namespace blink {
@@ -66,6 +67,7 @@ void PointerEventManager::clear() {
m_nodeUnderPointer.clear();
m_pointerCaptureTarget.clear();
m_pendingPointerCaptureTarget.clear();
+ m_dispatchingPointerId = 0;
}
DEFINE_TRACE(PointerEventManager) {
@@ -143,6 +145,7 @@ WebInputEventResult PointerEventManager::dispatchPointerEvent(
// Set whether node under pointer has received pointerover or not.
const int pointerId = pointerEvent->pointerId();
+
const AtomicString& eventType = pointerEvent->type();
if ((eventType == EventTypeNames::pointerout ||
eventType == EventTypeNames::pointerover) &&
@@ -159,11 +162,12 @@ WebInputEventResult PointerEventManager::dispatchPointerEvent(
if (!RuntimeEnabledFeatures::pointerEventEnabled())
return WebInputEventResult::NotHandled;
if (!checkForListener || target->hasEventListeners(eventType)) {
- UseCounter::count(m_frame->document(), UseCounter::PointerEventDispatch);
+ UseCounter::count(m_frame, UseCounter::PointerEventDispatch);
if (eventType == EventTypeNames::pointerdown)
- UseCounter::count(m_frame->document(),
- UseCounter::PointerEventDispatchPointerDown);
+ UseCounter::count(m_frame, UseCounter::PointerEventDispatchPointerDown);
+ DCHECK(!m_dispatchingPointerId);
+ AutoReset<int> dispatchHolder(&m_dispatchingPointerId, pointerId);
DispatchEventResult dispatchResult = target->dispatchEvent(pointerEvent);
return EventHandlingUtil::toWebInputEventResult(dispatchResult);
}
@@ -629,9 +633,14 @@ void PointerEventManager::elementRemoved(EventTarget* target) {
void PointerEventManager::setPointerCapture(int pointerId,
EventTarget* target) {
- UseCounter::count(m_frame->document(), UseCounter::PointerEventSetCapture);
- if (m_pointerEventFactory.isActiveButtonsState(pointerId))
+ UseCounter::count(m_frame, UseCounter::PointerEventSetCapture);
+ if (m_pointerEventFactory.isActiveButtonsState(pointerId)) {
+ if (pointerId != m_dispatchingPointerId) {
+ UseCounter::count(m_frame,
+ UseCounter::PointerEventSetCaptureOutsideDispatch);
+ }
m_pendingPointerCaptureTarget.set(pointerId, target);
+ }
}
void PointerEventManager::releasePointerCapture(int pointerId,
« no previous file with comments | « third_party/WebKit/Source/core/input/PointerEventManager.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698