Fix for fullscreen layout timing on Galaxy devices.

chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.fullscreen;
 
 import static android.view.View.SYSTEM_UI_FLAG_FULLSCREEN;
 import static android.view.View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN;
 import static android.view.View.SYSTEM_UI_FLAG_LOW_PROFILE;
 
@@ skipping 120 matching lines @@
                     contentView.addOnLayoutChangeListener(new OnLayoutChangeListener() {
                         @Override
                         public void onLayoutChange(View v, int left, int top, int right,
                                 int bottom, int oldLeft, int oldTop, int oldRight,
                                 int oldBottom) {
                             sendEmptyMessageDelayed(MSG_ID_CLEAR_LAYOUT_FULLSCREEN_FLAG,
                                     CLEAR_LAYOUT_FULLSCREEN_DELAY_MS);
                             contentView.removeOnLayoutChangeListener(this);
                         }
                     });
+
+                    // Request a layout so the updated system visibility takes affect.
+                    contentView.getRootView().requestLayout();

[Ted C, 2017/01/17 19:30:10]

Hmm...I added the case below because we weren't getting the first layout change
callback.

To be safe, I would leave it below and add it here.

[bokan, 2017/01/17 21:43:11]

You mean leave the removed lines in? Having the requestLayout both here and in
enterFullscreen doesn't work. Perhaps there's a bug in Android? It seems as if
LAYOUT_FULLSCREEN doesn't include the status bar in the layout height (at least
if there's no navigation bar to hide), but LAYOUT_FULLSCREEN -> FULLSCREEN
transition doesn't invalidate the layout. I can try this out in a simple app but
it'll have to wait until I get home, I don't have an android dev environment
setup on my laptop.

Anyway, if I keep requestLayout in enterFullscreen, we never get an
onLayoutChange, neither on the listener added there nor the one added here.

[Ted C, 2017/01/17 22:09:45]

Oh, that is rather unfortunate (and likely what your comment was referring to in
your original patch).  I had to add the request layout below otherwise it would
never get here in my local testing (probably a Nexus 5 of some incantation).

I'm afraid removing that below will break some device and the same here.

Oooh, is this only for clearing the fullscreen layout flag layout change
listener above?  If so, I think we can actually just remove it from the layout
change thing altogether and increase the timeout to something like 200MS instead
of 20MS.  Not exactly clean, but again, should be a clean merge and safer IMO.

[bokan, 2017/01/17 23:35:24]

Presumably because we send the MSG_ID_SET_FULLSCREEN_SYSTEM_UI_FLAGS from the
onLayoutChange, right? Shouldn't we get an onContentViewSystemUiVisibilityChange
when we go into LAYOUT_FULLSCREEN which will send the
MSG_ID_SET_FULLSCREEN_SYSTEM_UI_FLAGS message and lead us here?
No, the listener attached here doesn't seem to matter. In fact, this
requestLayout is a red herring, removing both makes it work on both the S7 and
Nexus 6. I'm seeing the onLayoutChange listener attached in enterFullscreen
called even without requestLayout. Perhaps the call to requestLayout makes us do
a layout before the status bar is hidden on S7 and since there's no navigation
bar, there's no geometry change?

Why did we need to explicitly requestLayout? Shouldn't changing the
systemUiVisibility automatically schedule a layout? 

                     break;
                 }
                 case MSG_ID_CLEAR_LAYOUT_FULLSCREEN_FLAG: {
                     // Change this assert to simply ignoring the message to work around
                     // http://crbug/365638
                     // TODO(aberent): Fix bug
                     // assert mIsPersistentMode : "Calling after we exited fullscreen";
                     if (!fullscreenHtmlApiHandler.getPersistentFullscreenMode()) return;
                     final ContentViewCore contentViewCore =
                             fullscreenHtmlApiHandler.mContentViewCoreInFullscreen;
@@ skipping 140 matching lines @@
                 if ((bottom - top) <= (oldBottom - oldTop)) return;
                 if (mDelegate.shouldShowNotificationToast()) {
                     showNotificationToast();
                 }
                 contentView.removeOnLayoutChangeListener(this);
             }
         };
         contentView.addOnLayoutChangeListener(mFullscreenOnLayoutChangeListener);
         contentView.setSystemUiVisibility(systemUiVisibility);
 
-        // Request a layout so the updated system visibility takes affect.
-        contentView.getRootView().requestLayout();
-
         mContentViewCoreInFullscreen = contentViewCore;
         mTabInFullscreen = tab;
     }
 
     /**
      * Create and show the fullscreen notification toast.
      */
     private void showNotificationToast() {
         if (mNotificationToast == null) {
             int resId = (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT)
@@ skipping 50 matching lines @@
     private static int getExtraFullscreenUIFlags() {
         int flags = 0;
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
             flags |= View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION;
             flags |= View.SYSTEM_UI_FLAG_HIDE_NAVIGATION;
             flags |= View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY;
         }
         return flags;
     }
 }