Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 263553012: Rename SK_DEBUGBREAK to SK_ALWAYSBREAK (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
Reviewers:
caryclark, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix XPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M include/core/SkPostConfig.h View 2 chunks +5 lines, -5 lines 0 comments Download
M include/core/SkTypes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 18 chunks +60 lines, -60 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
6 years, 7 months ago (2014-04-30 15:45:33 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-04-30 15:49:06 UTC) #2
reed1
+1000 lgtm
6 years, 7 months ago (2014-04-30 16:02:54 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 16:06:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/263553012/1
6 years, 7 months ago (2014-04-30 16:06:15 UTC) #5
commit-bot: I haz the power
Change committed as 14473
6 years, 7 months ago (2014-04-30 16:14:07 UTC) #6
bsalomon
A revert of this CL has been created in https://codereview.chromium.org/260763003/ by bsalomon@google.com. The reason for ...
6 years, 7 months ago (2014-04-30 16:27:04 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 18:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/263553012/20001
6 years, 7 months ago (2014-04-30 18:18:41 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 18:24:19 UTC) #10
Message was sent while issue was closed.
Change committed as 14481

Powered by Google App Engine
This is Rietveld 408576698