Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 263553011: Render comment for FilePath::ReferencesParent() more precisely. (Closed)

Created:
6 years, 7 months ago by Thiemo Nagel
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Render comment for FilePath::ReferencesParent() more precisely. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/files/file_path.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Thiemo Nagel
Hi Will, could you please take a look at this minimal change, too? Thanks! Thiemo
6 years, 7 months ago (2014-04-30 14:37:35 UTC) #1
willchan no longer on Chromium
lgtm Thanks for the cleanup.
6 years, 7 months ago (2014-04-30 14:53:25 UTC) #2
Thiemo Nagel
On 2014/04/30 14:53:25, willchan wrote: > lgtm > > Thanks for the cleanup. Thank you ...
6 years, 7 months ago (2014-04-30 15:50:48 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-04-30 15:50:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/263553011/1
6 years, 7 months ago (2014-04-30 15:52:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 15:57:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 15:57:22 UTC) #7
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-04-30 16:19:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/263553011/1
6 years, 7 months ago (2014-04-30 16:20:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 16:23:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 16:23:29 UTC) #11
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-05-01 08:21:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/263553011/1
6 years, 7 months ago (2014-05-01 08:22:32 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 09:12:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-01 09:12:44 UTC) #15
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-05-01 16:21:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/263553011/1
6 years, 7 months ago (2014-05-01 16:22:16 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 16:52:10 UTC) #18
Message was sent while issue was closed.
Change committed as 267540

Powered by Google App Engine
This is Rietveld 408576698