Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 263553005: Convert repaintRectsAsText callers to text-based-repaint.js (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Convert repaintRectsAsText callers to text-based-repaint.js This makes text-based-repaint.js the only repaintRectsAsText caller, which will make it easier to convert from FrameView to GraphicsLayer repaint rects. BUG=368518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173016

Patch Set 1 #

Patch Set 2 : Expectations and baselines #

Total comments: 2

Patch Set 3 : Remove duplicate issue 320139 rebaseline for css3/flexbox/repaint.html #

Patch Set 4 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -156 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/repaint/scroll-fixed-layer-no-content.html View 1 chunk +3 lines, -14 lines 0 comments Download
M LayoutTests/compositing/repaint/scroll-fixed-layer-out-of-view.html View 1 chunk +3 lines, -13 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint.html View 2 chunks +7 lines, -16 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-rtl-column.html View 2 chunks +6 lines, -17 lines 0 comments Download
M LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html View 2 chunks +5 lines, -26 lines 0 comments Download
M LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes.html View 2 chunks +5 lines, -26 lines 0 comments Download
M LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/fast/repaint/obscured-background-no-repaint.html View 3 chunks +8 lines, -17 lines 0 comments Download
M LayoutTests/fast/repaint/obscured-background-no-repaint-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/css3/flexbox/repaint-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
enne (OOO)
https://codereview.chromium.org/263553005/diff/20001/LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes-expected.txt File LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes-expected.txt (left): https://codereview.chromium.org/263553005/diff/20001/LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes-expected.txt#oldcode6 LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes-expected.txt:6: PASS repaintRects.indexOf('500') is not -1 This test and the ...
6 years, 7 months ago (2014-04-30 01:08:14 UTC) #1
ojan
lgtm
6 years, 7 months ago (2014-04-30 01:52:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/263553005/20001
6 years, 7 months ago (2014-04-30 01:53:52 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 02:02:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 02:02:13 UTC) #5
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-04-30 17:18:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/263553005/40001
6 years, 7 months ago (2014-04-30 17:19:00 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:21:12 UTC) #8
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-30 18:21:13 UTC) #9
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-04-30 18:32:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/263553005/60001
6 years, 7 months ago (2014-04-30 18:33:04 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 19:38:25 UTC) #12
Message was sent while issue was closed.
Change committed as 173016

Powered by Google App Engine
This is Rietveld 408576698