Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/browser/chromeos/feedback_util.cc

Issue 2635473003: Optimize sending sys info to the feedback app (Closed)
Patch Set: Xiyuan's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/feedback_private/feedback_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/feedback_util.cc
diff --git a/chrome/browser/chromeos/feedback_util.cc b/chrome/browser/chromeos/feedback_util.cc
index e3dc9dfb27ee7bb8ac2cdaa5acf2cfe5d8fcabd0..c629cd6dbadd02e9ff614e1389a093ba8850480a 100644
--- a/chrome/browser/chromeos/feedback_util.cc
+++ b/chrome/browser/chromeos/feedback_util.cc
@@ -23,22 +23,16 @@ extensions::FeedbackService* GetFeedbackService(Profile* profile) {
->GetService();
}
-void OnGetSystemInformation(Profile* profile,
- const std::string& description,
- const SendSysLogFeedbackCallback& callback,
- const extensions::SystemInformationList& sys_info) {
+void OnGetSystemInformation(
+ Profile* profile,
+ const std::string& description,
+ const SendSysLogFeedbackCallback& callback,
+ std::unique_ptr<system_logs::SystemLogsResponse> sys_info) {
scoped_refptr<FeedbackData> feedback_data(new FeedbackData());
feedback_data->set_context(profile);
feedback_data->set_description(description);
-
- std::unique_ptr<FeedbackData::SystemLogsMap> sys_logs(
- new FeedbackData::SystemLogsMap);
- for (const extensions::api::feedback_private::SystemInformation& info :
- sys_info) {
- (*sys_logs.get())[info.key] = info.value;
- }
- feedback_data->SetAndCompressSystemInfo(std::move(sys_logs));
+ feedback_data->SetAndCompressSystemInfo(std::move(sys_info));
GetFeedbackService(profile)->SendFeedback(profile, feedback_data, callback);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/feedback_private/feedback_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698