Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 263533003: Revert of Linux Aura: get tooltip background color from theme (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Visibility:
Public.

Description

Revert of Linux Aura: get tooltip background color from theme (https://codereview.chromium.org/258713002/) Reason for revert: views_unittest TooltipController test failures views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs ) stdio Capture CloseOnCaptureLost DontShowEmptyTooltips EnableOrDisableTooltips HideOnExit ReshowOnClickAfterEnterExit TooltipHidesOnKeyPressAndStaysHiddenUntilChange TooltipHidesOnTimeoutAndStaysHiddenUntilChange TooltipsInMultipleViews ViewTooltip TooltipControllerTest.ViewTooltip (run #2): [ RUN ] TooltipControllerTest.ViewTooltip Xlib: extension "RANDR" missing on display ":9". Received signal 11 SEGV_MAPERR 000000000000 #0 0x000000a88e4e base::debug::StackTrace::StackTrace() #1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f9474270cb0 \u003Cunknown> #3 0x000000736b83 views::NativeWidgetAura::Activate() #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState() #5 0x000000738acb views::Widget::Show() #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget() #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp() #8 0x00000065a16a testing::Test::Run() Original issue's description: > Linux Aura: get tooltip background color from theme > > the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc). > > BUG=348194 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974 TBR=ben@chromium.org,estade@chromium.org NOTREECHECKS=true NOTRY=true BUG=348194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/native_theme/fallback_theme.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robliao
Created Revert of Linux Aura: get tooltip background color from theme
6 years, 7 months ago (2014-04-29 23:12:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/263533003/1
6 years, 7 months ago (2014-04-29 23:14:06 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 23:17:12 UTC) #3
Message was sent while issue was closed.
Change committed as 266992

Powered by Google App Engine
This is Rietveld 408576698