Quit immediately in TestNavigationObserver.

content/public/test/test_navigation_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_TEST_NAVIGATION_OBSERVER_H_
 #define CONTENT_PUBLIC_TEST_TEST_NAVIGATION_OBSERVER_H_
 
 #include <memory>
 #include <set>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "content/public/test/test_utils.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace content {
 class RenderFrameHost;
 class WebContents;
 struct LoadCommittedDetails;
 
 // For browser_tests, which run on the UI thread, run a second
 // MessageLoop and quit when the navigation completes loading.
 class TestNavigationObserver {
  public:
   // Create and register a new TestNavigationObserver against the
   // |web_contents|.
   TestNavigationObserver(WebContents* web_contents,
-                         int number_of_navigations);
+                         int number_of_navigations,
+                         MessageLoopRunner::QuitMode quit_mode =
+                             MessageLoopRunner::QuitMode::IMMEDIATE);
   // Like above but waits for one navigation.
-  explicit TestNavigationObserver(WebContents* web_contents);
+  explicit TestNavigationObserver(WebContents* web_contents,

[nasko, 2017/01/20 22:54:45]

nit: Do we need for explicit anymore, as there are more than one parameters.

[Alexander Semashko, 2017/01/23 19:45:39]

Constructors should be explicit as long as it is possible to call them with a
single argument. In this case this is possible thanks to the second argument
having a default value. A note w.r.t. default arguments: they are allowed now in
non-virtual functions, and (I hope) this one is temporary and will be removed
when we sort out issues around NavigateToURL in browser_tests.

+                                  MessageLoopRunner::QuitMode quit_mode =
+                                      MessageLoopRunner::QuitMode::IMMEDIATE);
 
   virtual ~TestNavigationObserver();
 
   // Runs a nested message loop and blocks until the expected number of
   // navigations are complete.
   void Wait();
 
   // Start/stop watching newly created WebContents.
   void StartWatchingNewWebContents();
   void StopWatchingNewWebContents();
@@ skipping 54 matching lines @@
 
   // Living TestWebContentsObservers created by this observer.
   std::set<std::unique_ptr<TestWebContentsObserver>> web_contents_observers_;
 
   DISALLOW_COPY_AND_ASSIGN(TestNavigationObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_TEST_NAVIGATION_OBSERVER_H_