Pref service: expose all read-only PrefStores through Mojo

services/preferences/public/cpp/pref_store_manager_impl.h

Index: services/preferences/public/cpp/pref_store_manager_impl.h
diff --git a/services/preferences/public/cpp/pref_store_manager_impl.h b/services/preferences/public/cpp/pref_store_manager_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..d4c7dcb6f9abea5329ac05500d2521970c8d9fb1
--- /dev/null
+++ b/services/preferences/public/cpp/pref_store_manager_impl.h
@@ -0,0 +1,88 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_PREFERENCES_PUBLIC_CPP_PREF_STORE_MANAGER_IMPL_H_
+#define SERVICES_PREFERENCES_PUBLIC_CPP_PREF_STORE_MANAGER_IMPL_H_
+
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "components/prefs/pref_value_store.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
+#include "services/preferences/public/interfaces/preferences.mojom.h"
+#include "services/service_manager/public/cpp/interface_factory.h"
+#include "services/service_manager/public/cpp/service.h"
+
+namespace prefs {
+
+// This class mediates the connection of clients who wants to read preferences
+// and the pref stores that store those preferences. Pref stores use the
+// |PrefStoreRegistry| interface to register themselves with the manager and
+// clients use the |PrefStoreConnector| interface to connect to these stores.
+class PrefStoreManagerImpl
+    : public mojom::PrefStoreRegistry,
+      public mojom::PrefStoreConnector,
+      public service_manager::InterfaceFactory<mojom::PrefStoreConnector>,
+      public service_manager::InterfaceFactory<mojom::PrefStoreRegistry>,
+      public service_manager::Service {
+ public:
+  using PrefStoreTypes = std::set<PrefValueStore::PrefStoreType>;
+
+  // Only replies to Connect calls when all |expected_pref_stores| have
+  // registered.
+  PrefStoreManagerImpl(PrefStoreTypes expected_pref_stores);

[Sam McNally, 2017/03/03 03:47:58]

explicit

[tibell, 2017/03/07 00:52:52]

Done.

+  ~PrefStoreManagerImpl() override;
+
+  // PrefStores used by Chrome by default.

[Sam McNally, 2017/03/03 03:47:58]

That's a layering violation. This should be somewhere in chrome/browser/prefs.

[tibell, 2017/03/07 00:52:52]

Done.

I just removed this for now. We'll do the setup in another CL that hooks
everything up.

+  static PrefStoreTypes DefaultStores();
+
+ private:
+  // mojom::PrefStoreRegistry:
+  void Register(PrefValueStore::PrefStoreType type,
+                mojom::PrefStorePtr pref_store_ptr) override;
+
+  // mojom::PrefStoreConnector:
+  void Connect(const ConnectCallback& callback) override;
+
+  // service_manager::InterfaceFactory<PrefStoreConnector>:
+  void Create(const service_manager::Identity& remote_identity,
+              prefs::mojom::PrefStoreConnectorRequest request) override;
+
+  // service_manager::InterfaceFactory<PrefStoreRegistry>:
+  void Create(const service_manager::Identity& remote_identity,
+              prefs::mojom::PrefStoreRegistryRequest request) override;
+
+  // service_manager::Service:
+  void OnStart() override;
+  bool OnConnect(const service_manager::ServiceInfo& remote_info,
+                 service_manager::InterfaceRegistry* registry) override;
+
+  // Called when a PrefStore previously registered using |Register| disconnects.
+  void OnPrefStoreDisconnect(PrefValueStore::PrefStoreType type);
+
+  // Have all the expected PrefStores connected?
+  bool AllConnected() const;
+
+  // PrefStores that need to register before replying to any Connect calls.
+  PrefStoreTypes expected_pref_stores_;
+
+  using PrefStorePtrs =

[Sam McNally, 2017/03/03 03:47:58]

Types before methods.

[tibell, 2017/03/07 00:52:52]

Done.

+      std::unordered_map<PrefValueStore::PrefStoreType, mojom::PrefStorePtr>;
+
+  // Registered pref stores.
+  PrefStorePtrs pref_store_ptrs_;
+
+  mojo::BindingSet<mojom::PrefStoreConnector> connector_bindings_;
+  mojo::BindingSet<mojom::PrefStoreRegistry> registry_bindings_;
+
+  // We hold on to the connection request callbacks until all expected
+  // PrefStores have registered.
+  std::vector<ConnectCallback> pending_callbacks_;
+
+  DISALLOW_COPY_AND_ASSIGN(PrefStoreManagerImpl);
+};
+
+}  // namespace prefs
+
+#endif  // SERVICES_PREFERENCES_PUBLIC_CPP_PREF_STORE_MANAGER_IMPL_H_