Pref service: expose all read-only PrefStores through Mojo

components/prefs/pref_value_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PREFS_PREF_VALUE_STORE_H_
 #define COMPONENTS_PREFS_PREF_VALUE_STORE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 99 matching lines @@
   // there is no higher-priority source controlling it.
   bool PrefValueUserModifiable(const std::string& name) const;
 
   // Check whether a Preference value is modifiable by an extension, i.e.
   // whether there is no higher-priority source controlling it.
   bool PrefValueExtensionModifiable(const std::string& name) const;
 
   // Update the command line PrefStore with |command_line_prefs|.
   void UpdateCommandLinePrefStore(PrefStore* command_line_prefs);
 
- private:
   // PrefStores must be listed here in order from highest to lowest priority.
   //   MANAGED contains all managed preference values that are provided by
   //      mandatory policies (e.g. Windows Group Policy or cloud policy).
   //   SUPERVISED_USER contains preferences that are valid for supervised users.
   //   EXTENSION contains preference values set by extensions.
   //   COMMAND_LINE contains preference values set by command-line switches.
   //   USER contains all user-set preference values.
   //   RECOMMENDED contains all preferences that are provided by recommended
   //      policies.
   //   DEFAULT contains all application default preference values.
   enum PrefStoreType {

[Sam McNally, 2017/02/24 04:14:53]

Types before constructors.

[tibell, 2017/02/27 00:02:53]

Done.

     // INVALID_STORE is not associated with an actual PrefStore but used as
     // an invalid marker, e.g. as a return value.
     INVALID_STORE = -1,
     MANAGED_STORE = 0,
     SUPERVISED_USER_STORE,
     EXTENSION_STORE,
     COMMAND_LINE_STORE,
     USER_STORE,
     RECOMMENDED_STORE,
     DEFAULT_STORE,
     PREF_STORE_TYPE_MAX = DEFAULT_STORE
   };
 
+ private:
   // Keeps a PrefStore reference on behalf of the PrefValueStore and monitors
   // the PrefStore for changes, forwarding notifications to PrefValueStore. This
   // indirection is here for the sake of disambiguating notifications from the
   // individual PrefStores.
   class PrefStoreKeeper : public PrefStore::Observer {
    public:
     PrefStoreKeeper();
     ~PrefStoreKeeper() override;
 
     // Takes ownership of |pref_store|.
@@ skipping 95 matching lines @@
 
   // A mapping of preference names to their registered types.
   PrefTypeMap pref_types_;
 
   // True if not all of the PrefStores were initialized successfully.
   bool initialization_failed_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefValueStore);
 };
 
+namespace std {
+
+template <>
+struct hash<PrefValueStore::PrefStoreType> {
+  size_t operator()(const PrefValueStore::PrefStoreType& type) const {
+    return static_cast<std::size_t>(type);

[Sam McNally, 2017/02/24 04:14:53]

size_t for an enum with a -1?

[tibell, 2017/02/27 00:02:53]

Done.

+  }
+};
+
+}  // namespace std
+
 #endif  // COMPONENTS_PREFS_PREF_VALUE_STORE_H_