third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2635143002: Changed EBoxSizing to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2635143002: Changed EBoxSizing to an enum class and renamed its members (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 7a2f5486be031b2c5a5c377398182889b920dd08..ef0c1e6952c428ab62e2352fecfa45c6123d5024 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1082,7 +1082,7 @@ static LayoutRect sizingBox(const LayoutObject* layoutObject) {

return LayoutRect();

const LayoutBox* box = toLayoutBox(layoutObject);

- return box->style()->boxSizing() == BoxSizingBorderBox

+ return box->style()->boxSizing() == EBoxSizing::BorderBox

napper 2017/01/17 04:04:56 Did you mean to also add the 'k' prefix as per you

? box->borderBoxRect()

: box->computedCSSContentBoxRect();

}

@@ -2862,7 +2862,7 @@ const CSSValue* ComputedStyleCSSValueMapping::get(

return CSSPrimitiveValue::create(style.zoom(),

CSSPrimitiveValue::UnitType::Number);

case CSSPropertyBoxSizing:

- if (style.boxSizing() == BoxSizingContentBox)

+ if (style.boxSizing() == EBoxSizing::ContentBox)

return CSSIdentifierValue::create(CSSValueContentBox);

return CSSIdentifierValue::create(CSSValueBorderBox);

case CSSPropertyWebkitAppRegion: