Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2554)

Unified Diff: chrome/common/extensions/api/streams_private.idl

Issue 263513004: Forward MIME types to BrowserPlugin when a viewer is specified. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review fixes Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/streams_private.idl
diff --git a/chrome/common/extensions/api/streams_private.idl b/chrome/common/extensions/api/streams_private.idl
index 2d3badaa9a225760c474a66f5148ae817ce18ced..53e0eb985cf1111c62f8f1fc8b7f11363b117952 100644
--- a/chrome/common/extensions/api/streams_private.idl
+++ b/chrome/common/extensions/api/streams_private.idl
@@ -14,9 +14,11 @@ namespace streamsPrivate {
// The URL that the stream can be read from.
DOMString streamUrl;
- // The ID of the tab that opened the stream. If the stream is not opened in
- // a tab, it will be -1.
- long tabId;
+ // The ID of the tab that opened the stream.
not at google - send to devlin 2014/04/30 15:42:43 "Either/exactly-one-of |tabId| or |viewId| will be
Zachary Kuznia 2014/05/01 00:38:22 Reverted this to old language and behavior.
+ long? tabId;
+
+ // The ID of the view that will render the stream.
not at google - send to devlin 2014/04/30 15:42:43 ditto
Zachary Kuznia 2014/05/01 00:38:22 Clarified the conditions where this will be set.
+ DOMString? viewId;
// The amount of data the Stream should contain, if known. If there is no
// information on the size it will be -1.

Powered by Google App Engine
This is Rietveld 408576698