chrome/browser/chrome_content_browser_client.cc - Issue 263513004: Forward MIME types to BrowserPlugin when a viewer is specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 263513004: Forward MIME types to BrowserPlugin when a viewer is specified. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Send URLRequest instead of extra params Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 1bd14b9fe2a5ec001d8ef7d527ee359295c40291..d3c144e0178e28f97435b4e7d2e697a2f62a75ad 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -840,7 +840,11 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(

// instead of exiting early.

if (!extension_id.empty() &&

!service->GetExtensionById(extension_id, false)) {

- NOTREACHED();

+ *guest_delegate =

+ GuestViewBase::Create(guest_instance_id,

+ guest_web_contents,

+ extension_id,

+ "webview");

return;

}