[ash-md] Fixed Label::GetTextSize() to account for insets.

[ash-md] Fixed Label::GetTextSize() to account for insets.

Label::GetTextSize() was not properly accounting for insets.  This was
affecting Label::GetPreferredSize() and ultimately the visual layout of
a label could be incorrect.

BUG=678337

[bruthig, 2017-01-16 23:44:09]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2017-01-16 23:53:03]

bruthig@chromium.org changed reviewers:
+ msw@chromium.org

[bruthig, 2017-01-16 23:53:03]

msw@,

I've found at least one solution to the immediate problem however there are at
least a handful of others that may cause labels to not lay out well.  The other
issues found are in Label and BoxLayout.

Patch set 1 contains code to repro the problem documented in issue 678337 and a
fix for that particular use case.  However, patch set 2 uses a much longer
string that exceeds the maximum row height and should cause text eliding but it
doesn't.  Instead the text is clipped at the top and bottom again.  Note that
patch set 2 even uses Label::SizeToFit().

Can you...

- take a look a look at why text is not eliding or point me in the right
direction
- give your thoughts on the proposed solution in patch set 1 and how risky it
would be to merge back to M56, or get in to M57 for that matter

Thanks,
Ben

[commit-bot: I haz the power, 2017-01-17 00:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 00:21:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bruthig, 2017-01-17 23:10:09]

Just an update here.  I've found a less risky fix for issue 678337.  I will
close this review and create a new issue to track the bug(s) in Label.

[bruthig, 2017-01-17 23:10:16]

Description was changed from

==========
[ash-md] Fixed Label::GetTextSize() to account for insets.

Label::GetTextSize() was not properly accounting for insets.  This was
affecting Label::GetPreferredSize() and ultimately the visual layout of
a label could be incorrect.

BUG=678337
==========

to

==========
[ash-md] Fixed Label::GetTextSize() to account for insets.

Label::GetTextSize() was not properly accounting for insets.  This was
affecting Label::GetPreferredSize() and ultimately the visual layout of
a label could be incorrect.

BUG=678337
==========