Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/prefs/preferences_connection_manager.h

Issue 2635093002: Switch Preferences to use Factory (Closed)
Patch Set: Missed test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/preferences_connection_manager.h
diff --git a/chrome/browser/prefs/preferences_connection_manager.h b/chrome/browser/prefs/preferences_connection_manager.h
index 0f9e8dfe89750eab17ed529ed787a4744d5effdb..ebc85a27d9435ccb2a51be3a8019c027321c2717 100644
--- a/chrome/browser/prefs/preferences_connection_manager.h
+++ b/chrome/browser/prefs/preferences_connection_manager.h
@@ -10,6 +10,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "components/keyed_service/core/keyed_service_shutdown_notifier.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/preferences/public/interfaces/preferences.mojom.h"
#include "services/service_manager/public/cpp/interface_factory.h"
@@ -23,8 +24,9 @@
// TODO(jonross): Observe profile switching and update PreferenceManager
// connections.
class PreferencesConnectionManager
- : public NON_EXPORTED_BASE(
- service_manager::InterfaceFactory<prefs::mojom::PreferencesManager>),
+ : public NON_EXPORTED_BASE(prefs::mojom::PreferencesFactory),
+ public NON_EXPORTED_BASE(
+ service_manager::InterfaceFactory<prefs::mojom::PreferencesFactory>),
public NON_EXPORTED_BASE(service_manager::Service) {
public:
PreferencesConnectionManager();
@@ -39,18 +41,24 @@ class PreferencesConnectionManager
// the active PrefService is being destroyed.
void OnProfileDestroyed();
- // service_manager::InterfaceFactory<PreferencesManager>:
+ // prefs::mojom::PreferencesFactory:
+ void Create(prefs::mojom::PreferencesObserverPtr observer,
+ prefs::mojom::PreferencesManagerRequest manager) override;
+
+ // service_manager::InterfaceFactory<PreferencesFactory>:
void Create(const service_manager::Identity& remote_identity,
- prefs::mojom::PreferencesManagerRequest request) override;
+ prefs::mojom::PreferencesFactoryRequest request) override;
// service_manager::Service:
void OnStart() override;
bool OnConnect(const service_manager::ServiceInfo& remote_info,
service_manager::InterfaceRegistry* registry) override;
+ mojo::BindingSet<prefs::mojom::PreferencesFactory> factory_bindings_;
+
// Bindings that automatically cleanup during connection errors.
std::vector<mojo::StrongBindingPtr<prefs::mojom::PreferencesManager>>
- bindings_;
+ manager_bindings_;
// Observes shutdown, when PrefService is being destroyed.
std::unique_ptr<KeyedServiceShutdownNotifier::Subscription>

Powered by Google App Engine
This is Rietveld 408576698