Switch Preferences to use Factory

chrome/browser/prefs/preferences_connection_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/preferences_connection_manager.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/preferences_manager.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 29 matching lines @@
 }  // namespace
 
 PreferencesConnectionManager::PreferencesConnectionManager() {}
 
 PreferencesConnectionManager::~PreferencesConnectionManager() {}
 
 void PreferencesConnectionManager::OnConnectionError(
     mojo::StrongBindingPtr<prefs::mojom::PreferencesManager> binding) {
   if (!binding)
     return;
-  for (auto it = std::begin(bindings_); it != std::end(bindings_); ++it) {
+  for (auto it = std::begin(manager_bindings_);

[sky, 2017/01/17 23:45:04]

Why do you need std::begin/std::end here?

[jonross, 2017/01/18 23:13:02]

I need the iterator for std::vector.erase, and ranged-based for loops do not
resolve to that. :(

Nor do we support bound params for lambdas yet, so I can't just use
std::remove_if :(

[sky, 2017/01/18 23:38:25]

Sorry for not being clear. I'm asking why you can't do:

for (auto it = manager_bindings_.begin(); it != manager_bindings_.end(); ++it) {
...
}

Maybe I'm missing something?

[jonross, 2017/01/19 15:24:13]

You aren't missing anything, and now I'm wondering why I wrote it that way to
being with... fixed.

+       it != std::end(manager_bindings_); ++it) {
     if (it->get() == binding.get()) {
-      bindings_.erase(it);
+      manager_bindings_.erase(it);
       return;
     }
   }
 }
 
 void PreferencesConnectionManager::OnProfileDestroyed() {
-  for (auto& it : bindings_) {
+  for (auto& it : manager_bindings_) {
     // Shutdown any PreferenceManager that is still alive.
     if (it)
       it->Close();
   }
 
   profile_shutdown_notification_.reset();
 }
 
 void PreferencesConnectionManager::Create(
-    const service_manager::Identity& remote_identity,
-    prefs::mojom::PreferencesManagerRequest request) {
+    prefs::mojom::PreferencesObserverPtr observer,
+    prefs::mojom::PreferencesManagerRequest manager) {
   // Certain tests have no profiles to connect to, and static initializers
   // which block the creation of test profiles.
   if (!g_browser_process->profile_manager()->GetNumberOfProfiles())
     return;
 
   Profile* profile = ProfileManager::GetActiveUserProfile();
   mojo::StrongBindingPtr<prefs::mojom::PreferencesManager> binding =
-      mojo::MakeStrongBinding(base::MakeUnique<PreferencesManager>(profile),
-                              std::move(request));
+      mojo::MakeStrongBinding(
+          base::MakeUnique<PreferencesManager>(std::move(observer), profile),
+          std::move(manager));
   // Copying the base::WeakPtr for future deletion.
   binding->set_connection_error_handler(
       base::Bind(&PreferencesConnectionManager::OnConnectionError,
                  base::Unretained(this), binding));
-  bindings_.push_back(std::move(binding));
+  manager_bindings_.push_back(std::move(binding));
+}
+
+void PreferencesConnectionManager::Create(
+    const service_manager::Identity& remote_identity,
+    prefs::mojom::PreferencesFactoryRequest request) {
+  factory_bindings_.AddBinding(this, std::move(request));
 }
 
 void PreferencesConnectionManager::OnStart() {
   // Certain tests have no profiles to connect to, and static initializers
   // which block the creation of test profiles.
   if (!g_browser_process->profile_manager()->GetNumberOfProfiles())
     return;
 
   profile_shutdown_notification_ =
       ShutdownNotifierFactory::GetInstance()
           ->Get(ProfileManager::GetActiveUserProfile())
           ->Subscribe(
               base::Bind(&PreferencesConnectionManager::OnProfileDestroyed,
                          base::Unretained(this)));
 }
 
 bool PreferencesConnectionManager::OnConnect(
     const service_manager::ServiceInfo& remote_info,
     service_manager::InterfaceRegistry* registry) {
-  registry->AddInterface<prefs::mojom::PreferencesManager>(this);
+  registry->AddInterface<prefs::mojom::PreferencesFactory>(this);
   return true;
 }