Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(462)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/prefs/preferences_manifest.json
Issue
2635093002
:
Switch Preferences to use Factory (Closed)
Patch Set: Missed test
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
ash/common/wm_shell.cc
chrome/browser/prefs/preferences_connection_manager.h
chrome/browser/prefs/preferences_connection_manager.cc
chrome/browser/prefs/preferences_manager.h
chrome/browser/prefs/preferences_manager.cc
chrome/browser/prefs/preferences_manager_unittest.cc
chrome/browser/prefs/preferences_manifest.json
services/preferences/public/cpp/pref_observer_store.h
services/preferences/public/cpp/pref_observer_store.cc
services/preferences/public/cpp/tests/pref_observer_store_unittest.cc
services/preferences/public/interfaces/preferences.mojom
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/prefs/preferences_manager_unittest.cc
('k') |
services/preferences/public/cpp/pref_observer_store.h »
('j') |
services/preferences/public/interfaces/preferences.mojom »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "name": "preferences",
2 "name": "preferences",
3 "display_name": "Preferences",
3 "display_name": "Preferences",
4 "interface_provider_specs": {
4 "interface_provider_specs": {
5 "service_manager:connector": {
5 "service_manager:connector": {
6 "provides": {
6 "provides": {
7
"preferences_manager": [ "prefs::mojom::
PreferencesManager
" ]
7
"preferences_manager": [ "prefs::mojom::
PreferencesFactory
" ]
8 },
8 },
9 "requires": {
9 "requires": {
10 }
10 }
11 }
11 }
12 }
12 }
13 }
13 }
OLD
NEW
« no previous file with comments
|
« chrome/browser/prefs/preferences_manager_unittest.cc
('k') |
services/preferences/public/cpp/pref_observer_store.h »
('j') |
services/preferences/public/interfaces/preferences.mojom »
('J')
Issue 2635093002: Switch Preferences to use Factory (Closed)
Created 3 years, 11 months ago by jonross
Modified 3 years, 11 months ago
Reviewers: dcheng, sky, Ben Goodger (Google)
Base URL:
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 2635093002:
Switch Preferences to use Factory (Closed)
