Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: third_party/WebKit/PRESUBMIT.py

Issue 2635033005: Add html5lib to the list of modules in webkitpy/thirdparty/wpt/wpt/tools. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Blink. 5 """Top-level presubmit script for Blink.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
11 import os 11 import os
12 import re 12 import re
13 import sys 13 import sys
14 14
15 15
16 _EXCLUDED_PATHS = ( 16 _EXCLUDED_PATHS = (
17 # LayoutTests/imported is excluded because these files are automatically 17 # LayoutTests/imported is excluded because these files are automatically
18 # imported, so we do not have direct control over their content. 18 # imported, so we do not have direct control over their content.
19 r'^third_party[\\\/]WebKit[\\\/]LayoutTests[\\\/]imported[\\\/].*', 19 r'^third_party[\\\/]WebKit[\\\/]LayoutTests[\\\/]imported[\\\/].*',
20 # Also created and imported via a script:
21 r'^third_party[\\\/]WebKit[\\\/]Tools[\\\/]Scripts[\\\/]webkitpy[\\\/]thirdp arty[\\\/]wpt[\\\/]wpt[\\\/].*',
qyearsley 2017/01/17 19:08:29 There is one file in here (wpt/tools/html5lib/ihat
20 ) 22 )
21 23
22 24
23 def _CheckForNonBlinkVariantMojomIncludes(input_api, output_api): 25 def _CheckForNonBlinkVariantMojomIncludes(input_api, output_api):
24 pattern = input_api.re.compile(r'#include\s+.+\.mojom(.*)\.h[>"]') 26 pattern = input_api.re.compile(r'#include\s+.+\.mojom(.*)\.h[>"]')
25 errors = [] 27 errors = []
26 for f in input_api.AffectedFiles(): 28 for f in input_api.AffectedFiles():
27 for line_num, line in f.ChangedContents(): 29 for line_num, line in f.ChangedContents():
28 m = pattern.match(line) 30 m = pattern.match(line)
29 if m and m.group(1) != '-blink' and m.group(1) != '-shared': 31 if m and m.group(1) != '-blink' and m.group(1) != '-shared':
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 new_description = description 378 new_description = description
377 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) 379 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
378 results.append(output_api.PresubmitNotifyResult( 380 results.append(output_api.PresubmitNotifyResult(
379 'Automatically added slimming-paint-v2 tests to run on CQ due to ' 381 'Automatically added slimming-paint-v2 tests to run on CQ due to '
380 'changes in paint or compositing directories.')) 382 'changes in paint or compositing directories.'))
381 383
382 if new_description != description: 384 if new_description != description:
383 rietveld_obj.update_description(issue, new_description) 385 rietveld_obj.update_description(issue, new_description)
384 386
385 return results 387 return results
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698