Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2635033004: Revert "added Range.toString() to dart:html (#28376)" +1 more (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
Reviewers:
Bill Hesse, Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "added Range.toString() to dart:html (#28376)" +1 more Revert "dart2js status updates after Range.toString was added to dart:html" This reverts commit 226a7e7177aee3cfb3bcc625535f59fe39f13212. This reverts commit c279a951f490cf4327931f02b5f2b6abf282f640. The test co19/LayoutTests/fast/filesystem/file-writer-abort-continue_t01 broke after the inital commit. The second commit being reverted is one that updated the status files for tests that now pass. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/8701dbf1476ddf116090742ea6462a28af9e0a7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 13 chunks +47 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
I don't like to revert commits from external contributors, given that they are probably relying ...
3 years, 11 months ago (2017-01-17 16:02:50 UTC) #2
Bill Hesse
LGTM. We don't know if all of the current failures come from this commit, or ...
3 years, 11 months ago (2017-01-17 16:16:38 UTC) #3
asgerf
Committed patchset #1 (id:1) manually as 8701dbf1476ddf116090742ea6462a28af9e0a7e (presubmit successful).
3 years, 11 months ago (2017-01-17 16:21:56 UTC) #5
Alan Knight
3 years, 11 months ago (2017-01-17 17:58:26 UTC) #6
Message was sent while issue was closed.
Sorry about that. It looked like a pretty trivial change, and I just ran the
html tests locally, not co19. I didn't expect us to have tests that were relying
on the fixed toString behavior and marked as failures.

The file writer issue doesn't seem to be related.

Powered by Google App Engine
This is Rietveld 408576698