Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.h

Issue 2635023005: Minor improvements to RecentTabHelper. (Closed)
Patch Set: A couple more things I had forgotten. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.h b/chrome/browser/android/offline_pages/recent_tab_helper.h
index 94c69e4ff1bd586eb30f75bfb41957955e2ebe7a..b57acb44cca0980a939c5e2c9c3cf0b6877f4813 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.h
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.h
@@ -102,18 +102,19 @@ class RecentTabHelper
void ReportDownloadStatusToRequestCoordinator();
bool IsSamePage() const;
ClientId GetRecentPagesClientId() const;
+ bool isSnapshottingForLastN() const;
dewittj 2017/01/17 23:21:52 This method feels like it should be part of Downlo
carlosk 2017/01/18 03:06:10 Done.
// Page model is a service, no ownership. Can be null - for example, in
// case when tab is in incognito profile.
- OfflinePageModel* page_model_;
+ OfflinePageModel* page_model_ = nullptr;
// If false, never make snapshots off the attached WebContents.
// Not page-specific.
- bool snapshots_enabled_;
+ bool snapshots_enabled_ = false;
// Becomes true during navigation if the page is ready for snapshot as
// indicated by at least one callback from SnapshotController.
- bool is_page_ready_for_snapshot_;
+ bool is_page_ready_for_snapshot_ = false;
// Info for the offline page to capture. Null if the tab is not capturing
// current page.

Powered by Google App Engine
This is Rietveld 408576698