Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

Issue 2635023002: [tracing] Support new heap dump format (Closed)
Patch Set: fix bug''fix bug Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
index 496d4faa092aab39f99429001843c1cdeba5a4c0..920d746c94ed31882f102f5f020b330e4d4843ed 100644
--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
@@ -190,7 +190,6 @@ tr.exportTo('tr.ui.analysis', function() {
convertStackFrameNodeDimensionToChildDict_(
stackFrameNode, dimensionIndex) {
const childDict = {};
-
let displayedChildrenTotalSize = 0;
let displayedChildrenTotalCount = 0;
let hasDisplayedChildren = false;
@@ -432,11 +431,16 @@ tr.exportTo('tr.ui.analysis', function() {
const objectTypeNamePath = objectTypeName === undefined ?
[] : [objectTypeName];
+ const valueKind = entry.valuesAreTotals ?
+ MultiDimensionalViewBuilder.ValueKind.TOTAL :
+ MultiDimensionalViewBuilder.ValueKind.SELF;
+
builder.addPath([stackTracePath, objectTypeNamePath],
[entry.size, entry.count],
- MultiDimensionalViewBuilder.ValueKind.TOTAL);
+ valueKind);
}
+ builder.complete = heapDump.isComplete;
this.cachedBuilders_.set(heapDump, builder);
return builder;
},
« no previous file with comments | « tracing/tracing/model/heap_dump.html ('k') | tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698