Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2635013002: Remove windows svn dependency from DEPS (Closed)

Created:
3 years, 11 months ago by Sam Clegg
Modified:
3 years, 10 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Remove windows svn dependency from DEPS On windows we were using an svn DEPS entry to gain access to cygtar from the native_client/build directory. Rather than requesting a new git mirror of the build directory this change simply duplictates the cygtar.py file in the webports repo. BUG=https://bugs.chromium.org/p/webports/issues/detail?id=255 R=binji@chromium.org Committed: https://chromium.googlesource.com/webports/+/dacf61d1a224b9e3c3f6678aa296e92d993dcba8

Patch Set 1 #

Patch Set 2 : Remove windows svn dependency from DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -7 lines) Patch
M DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A build_tools/cygtar.py View 1 chunk +424 lines, -0 lines 0 comments Download
M build_tools/download_sdk.py View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sam Clegg
3 years, 11 months ago (2017-01-16 16:26:33 UTC) #2
binji
lgtm
3 years, 11 months ago (2017-01-17 19:24:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635013002/20001
3 years, 11 months ago (2017-01-17 19:29:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: webports-presubmit on master.tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/webports-presubmit/builds/185)
3 years, 11 months ago (2017-01-17 19:31:47 UTC) #7
Sam Clegg
Committed patchset #2 (id:20001) manually as dacf61d1a224b9e3c3f6678aa296e92d993dcba8.
3 years, 11 months ago (2017-01-17 21:06:26 UTC) #9
davidgreens
3 years, 10 months ago (2017-02-25 01:18:02 UTC) #10
Message was sent while issue was closed.
On 2017/01/17 21:06:26, Sam Clegg wrote:
> Committed patchset #2 (id:20001) manually as
> dacf61d1a224b9e3c3f6678aa296e92d993dcba8.

@hektve87.1
GLint h = height;
while (--h > 0) {
bcopy(&data[h * bytesPerRow], &flipped[(height - h) * bytesPerRow],
bytesPerRow);
}
glPixelStorei(GL_UNPACK_ALIGNMENT, 4);
glPixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerRow / (bitsPerPixel / 8));
glDrawPixels(width, height, format, GL_UNSIGNED_BYTE, flipped);

Powered by Google App Engine
This is Rietveld 408576698