Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4654)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

Issue 26350003: OLD: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix integer overflow w/ kint32max, add test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
index 62d9a078f5d06e99b2b35e5ca29a28c0190d94ec..691b551a4c37a1a03df22e93bca050f2e5c2624d 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
@@ -39,6 +39,11 @@ class AcceleratorProvider;
class RecentTabsSubMenuModel : public ui::SimpleMenuModel,
public ui::SimpleMenuModel::Delegate {
public:
+ // Command Id for recently closed items header or disabled item to which the
+ // accelerator string will be appended.
+ static const int kRecentlyClosedHeaderCommandId;
+ static const int kDisabledRecentlyClosedHeaderCommandId;
+
// If |associator| is NULL, default associator for |browser|'s profile will
// be used. Testing may require a specific |associator|.
RecentTabsSubMenuModel(ui::AcceleratorProvider* accelerator_provider,
@@ -60,14 +65,6 @@ class RecentTabsSubMenuModel : public ui::SimpleMenuModel,
std::string* url,
string16* title) const;
- // Command Id for recently closed items header or disabled item to which the
- // accelerator string will be appended.
- static const int kRecentlyClosedHeaderCommandId;
- static const int kDisabledRecentlyClosedHeaderCommandId;
-
- // Command Id for other devices section headers, using the device name.
- static const int kDeviceNameCommandId;
-
private:
struct TabNavigationItem;
typedef std::vector<TabNavigationItem> TabNavigationItems;

Powered by Google App Engine
This is Rietveld 408576698