Correctly report the type of initializing formals declared without an explicit type to be the type …

tests/lib/mirrors/initializing_formals_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.initializing_formals;
 
 import 'dart:mirrors';
 import 'package:expect/expect.dart';
 
 class Class<T> {
   int intField;
   bool boolField;
   String stringField;
   T tField;
   dynamic _privateField;
 
   Class.nongeneric(this.intField);
   Class.named({this.boolField});
   Class.optPos([this.stringField = 'default']);
   Class.generic(this.tField);
   Class.private(this._privateField);
+
+  Class.explicitType(num this.intField);

[hausner, 2013/10/07 23:03:08]

Try also with explicit dynamic.

[rmacnak, 2013/10/08 01:01:01]

Done.

+  Class.withVar(var this.intField);
 }

[hausner, 2013/10/07 23:03:08]

Should you cover factories and forwarding constructors?

[rmacnak, 2013/10/08 01:01:01]

Initializing formals aren't allowed there.

 
 class Constant {
-  final value;
+  final num value;
   const Constant(this.value);
   const Constant.marked(final this.value);
 }
 
 main() {
   ParameterMirror pm;
 
   pm = reflectClass(Class).constructors[#Class.nongeneric].parameters.single;
   Expect.equals(#intField, pm.simpleName);
-  Expect.equals(reflectClass(int), pm.type);  /// 01: ok
+  Expect.equals(reflectClass(int), pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isFalse(pm.isFinal);
   Expect.isFalse(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
   
   pm = reflectClass(Class).constructors[#Class.named].parameters.single;
   Expect.equals(#boolField, pm.simpleName);
-  Expect.equals(reflectClass(bool), pm.type);  /// 01: ok
+  Expect.equals(reflectClass(bool), pm.type);
   Expect.isTrue(pm.isNamed);
   Expect.isFalse(pm.isFinal);
   Expect.isTrue(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
   
   pm = reflectClass(Class).constructors[#Class.optPos].parameters.single;
   Expect.equals(#stringField, pm.simpleName);
-  Expect.equals(reflectClass(String), pm.type);  /// 01: ok
+  Expect.equals(reflectClass(String), pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isFalse(pm.isFinal);
   Expect.isTrue(pm.isOptional);
   Expect.isTrue(pm.hasDefaultValue);
   Expect.equals('default', pm.defaultValue.reflectee);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
   
   pm = reflectClass(Class).constructors[#Class.generic].parameters.single;
   Expect.equals(#tField, pm.simpleName);
-  Expect.equals(reflectClass(Class).typeVariables.single, pm.type);  /// 01: ok
+  Expect.equals(reflectClass(Class).typeVariables.single, pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isFalse(pm.isFinal);
   Expect.isFalse(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
 
   pm = reflectClass(Class).constructors[#Class.private].parameters.single;
   Expect.equals(#_privateField, pm.simpleName);
   Expect.equals(currentMirrorSystem().dynamicType, pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isFalse(pm.isFinal);
   Expect.isFalse(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isTrue(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
 
+  pm = reflectClass(Class).constructors[#Class.explicitType].parameters.single;
+  Expect.equals(#intField, pm.simpleName);
+  Expect.equals(reflectClass(num), pm.type);
+  Expect.isFalse(pm.isNamed);
+  Expect.isFalse(pm.isFinal);
+  Expect.isFalse(pm.isOptional);
+  Expect.isFalse(pm.hasDefaultValue);
+  Expect.isFalse(pm.isPrivate);
+  Expect.isFalse(pm.isStatic);
+  Expect.isFalse(pm.isTopLevel);
+
+  pm = reflectClass(Class).constructors[#Class.withVar].parameters.single;
+  Expect.equals(#intField, pm.simpleName);
+  Expect.equals(reflectClass(int), pm.type);  // N.B.
+  Expect.isFalse(pm.isNamed);
+  Expect.isFalse(pm.isFinal);
+  Expect.isFalse(pm.isOptional);
+  Expect.isFalse(pm.hasDefaultValue);
+  Expect.isFalse(pm.isPrivate);
+  Expect.isFalse(pm.isStatic);
+  Expect.isFalse(pm.isTopLevel);
+
   pm = reflectClass(Constant).constructors[#Constant].parameters.single;
   Expect.equals(#value, pm.simpleName);
-  Expect.equals(currentMirrorSystem().dynamicType, pm.type);
+  Expect.equals(reflectClass(num), pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isFalse(pm.isFinal);  // N.B.
   Expect.isFalse(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
 
   pm = reflectClass(Constant).constructors[#Constant.marked].parameters.single;
   Expect.equals(#value, pm.simpleName);
-  Expect.equals(currentMirrorSystem().dynamicType, pm.type);
+  Expect.equals(reflectClass(num), pm.type);
   Expect.isFalse(pm.isNamed);
   Expect.isTrue(pm.isFinal);  // N.B.
   Expect.isFalse(pm.isOptional);
   Expect.isFalse(pm.hasDefaultValue);
   Expect.isFalse(pm.isPrivate);
   Expect.isFalse(pm.isStatic);
   Expect.isFalse(pm.isTopLevel);
 }