Correctly report the type of initializing formals declared without an explicit type to be the type …

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
+#include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/port.h"
 #include "vm/resolver.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
@@ skipping 80 matching lines @@
     Exceptions::PropagateError(Error::Cast(id_obj));
     UNREACHABLE();
   }
   ASSERT(id_obj.IsSmi() || id_obj.IsMint());
   Integer& id = Integer::Handle();
   id ^= id_obj.raw();
   Dart_Port port_id = static_cast<Dart_Port>(id.AsInt64Value());
   return Bool::Get(PortMap::IsLocalPort(port_id)).raw();
 }
 
+static void EnsureConstructorsAreCompiled(const Function& func) {
+  if (func.kind() != RawFunction::kConstructor) return;
+  const Class& cls = Class::Handle(func.Owner());
+  const Error& error = Error::Handle(cls.EnsureIsFinalized(Isolate::Current()));
+  if (!error.IsNull()) {
+    ThrowInvokeError(error);
+    UNREACHABLE();
+  }
+  if (!func.HasCode()) {
+    const Error& error = Error::Handle(Compiler::CompileFunction(func));
+    if (!error.IsNull()) {
+      ThrowInvokeError(error);
+      UNREACHABLE();
+    }
+  }
+}
 
 static RawInstance* CreateParameterMirrorList(const Function& func,
                                               const Instance& owner_mirror) {
   HANDLESCOPE(Isolate::Current());
   const intptr_t implicit_param_count = func.NumImplicitParameters();
   const intptr_t non_implicit_param_count = func.NumParameters() -
                                             implicit_param_count;
   const intptr_t index_of_first_optional_param =
       non_implicit_param_count - func.NumOptionalParameters();
   const intptr_t index_of_first_named_param =
       non_implicit_param_count - func.NumOptionalNamedParameters();
   const Array& results = Array::Handle(Array::New(non_implicit_param_count));
   const Array& args = Array::Handle(Array::New(9));
 
   // Return for synthetic functions and getters.
   if (func.IsGetterFunction() ||
       func.IsImplicitConstructor() ||
       func.IsImplicitGetterFunction() ||
       func.IsImplicitSetterFunction()) {
     return results.raw();
   }
 
   Smi& pos = Smi::Handle();
   String& name = String::Handle();
   Instance& param = Instance::Handle();
   Bool& is_final = Bool::Handle();
   Object& default_value = Object::Handle();
   Object& metadata = Object::Handle();
 
+  // We force compilation of constructors to ensure the types of initializing
+  // formals have been corrected. We do not force the compilation of all types
+  // of functions because some have no body, e.g. signature functions.
+  EnsureConstructorsAreCompiled(func);
+
   // Reparse the function for the following information:
   // * The default value of a parameter.
   // * Whether a parameters has been deflared as final.
   // * Any metadata associated with the parameter.
   const Object& result = Object::Handle(Parser::ParseFunctionParameters(func));
   if (result.IsError()) {
     ThrowInvokeError(Error::Cast(result));
     UNREACHABLE();
   }
 
@@ skipping 1545 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
   return field.type();
 }
 
 }  // namespace dart