Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: android_webview/BUILD.gn

Issue 2634563002: android_webview: support building a stub WebView. (Closed)
Patch Set: add comment describing new option Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 5aa72f8301abd552bf2917939022fa1baf4fccde..b92298ba2dce4351024400bbba8af1969896be21 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -28,6 +28,11 @@ if (enable_resource_whitelist_generation) {
system_webview_android_manifest =
"$target_gen_dir/system_webview_apk/AndroidManifest.xml"
+# TODO(torne): uncomment this once Android is updated to support loading this
jbudorick 2017/02/28 16:36:27 I think I'd prefer this be omitted until Android i
michaelbai 2017/02/28 18:58:39 Agreed, since there is internal target, once Andro
Torne 2017/03/01 10:56:29 No, we won't upstream the internal target - it has
michaelbai 2017/03/01 17:15:35 Thanks, I actually thought about the same thing, '
+# form of stub APK.
+#system_webview_stub_android_manifest =
+# "$target_gen_dir/system_webview_stub_apk/AndroidManifest.xml"
+
group("android_webview") {
if (!use_webview_internal_framework) {
deps = [
@@ -42,6 +47,20 @@ jinja_template("system_webview_manifest") {
variables = [ "package=$system_webview_package_name" ]
}
+# TODO(torne): uncomment this once Android is updated to support loading this
+# form of stub APK.
+#jinja_template("system_webview_stub_manifest") {
+# input = "apk/java/AndroidManifest.xml"
+# output = system_webview_stub_android_manifest
+# variables = [
+# "package=$system_webview_package_name",
+# "library=libmonochrome.so",
+# "donor_package=org.chromium.chrome",
+# "minsdk=TBD",
+# "targetsdk=TBD",
+# ]
+#}
+
webview_repack_locales("repack_locales") {
input_locales = locales
output_locales = locales
@@ -807,4 +826,15 @@ if (!use_webview_internal_framework) {
]
apk_name = "SystemWebView"
}
+ # TODO(torne): uncomment this once Android is updated to support loading this
+ # form of stub APK.
+ #android_apk("system_webview_stub_apk") {
+ # android_manifest = system_webview_stub_android_manifest
+ # android_manifest_dep = ":system_webview_stub_manifest"
+ # deps = [
+ # ":system_webview_resources",
+ # ]
+ # apk_name = "SystemWebViewStub"
+ # generate_buildconfig_java = false
+ #}
}
« no previous file with comments | « no previous file | android_webview/apk/java/AndroidManifest.xml » ('j') | android_webview/apk/java/AndroidManifest.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698